Adds support for folder/* patterns in .fleetignore #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of now, the `folder/*` was not supported by Fleet.
This PR adds support for it, giving the option to ignore folders (not files with a given name).
For example:
This folder structure:
```
root
dir1
test
file1
file2
file3
test
file4
```
with the following `.fleetignore` file:
```
test/*
```
would produce the following recource list:
```
root/file3
root/test
root/file4
```
`test` folder would be ignored but `test` file would not.
Signed-off-by: Xavi Garcia <[email protected]>
manno
pushed a commit
that referenced
this pull request
Jul 23, 2024
As of now, the `folder/*` was not supported by Fleet.
This PR adds support for it, giving the option to ignore folders (not files with a given name).
For example:
This folder structure:
```
root
dir1
test
file1
file2
file3
test
file4
```
with the following `.fleetignore` file:
```
test/*
```
would produce the following recource list:
```
root/file3
root/test
root/file4
```
`test` folder would be ignored but `test` file would not.
Signed-off-by: Xavi Garcia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, the
folder/*was not supported by Fleet.This PR adds support for it, giving the option to ignore folders (not files) with a given name.
For example:
This folder structure:
with the following
.fleetignorefile:would produce the following recource list:
testfolder would be ignored buttestfile would not.The difference with a
.fleetignorefile like this:is that both the
testflile anddir1/testfolder would be ignored.Refers to: #2175