Use RequeueAfter for Gitpolling job. #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the Manager's timers instead of creating a different go routine to deal with the polling job. This is an approach to deal with multiple calls updating the status of a `gitrepo` in the same reconcile loop. There were issues setting the status and getting it in the same reconcile as the cache was not properly set yet. This tries to fix those issues by only updating the status once per reconcile. Refers to: rancher#2631 Signed-off-by: Xavi Garcia <[email protected]>
0xavi0
force-pushed
the
2631-gitrepo-status-race-conditions
branch
from
a74fc3a to
98adea9
Compare
manno
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the Manager's timers instead of creating a different go routine to deal with the polling job.
This is an approach to deal with multiple calls updating the status of a
gitrepoin the same reconcile loop. There were issues setting the status and getting it in the same reconcile as the cache was not properly set yet.This tries to fix those issues by only updating the status once per reconcile.
It also adds a new condition specific for the
GitPollingtask.It has been tested with
rancher 2.9-headRefers to: #2631