Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PodSelector and ignore-errors as a parameter to the drain command #218

Open
rajivml opened this issue Jan 6, 2023 · 2 comments
Open

PodSelector and ignore-errors as a parameter to the drain command #218

rajivml opened this issue Jan 6, 2023 · 2 comments

Comments

@rajivml
Copy link

rajivml commented Jan 6, 2023

HI,

We have started exploring system-upgrade-controller for our upgrades but for us to onboard we want podselector and ignore-errors as additional parameters that can be passed to drain command

Today in our production this is how we drain the node as per longhorn's recommendation,

kubectl drain "$HOST_NAME_NODE" --delete-emptydir-data --ignore-daemonsets --force --disable-eviction=true --timeout=30s --ignore-errors --skip-wait-for-delete-timeout=10 --pod-selector 'app!=csi-attacher,longhorn.io/component!=instance-manager,k8s-app!=kube-dns'

Can we have this added, please

@rajivml
Copy link
Author

rajivml commented Jan 6, 2023

looks like there is already an open ticket and PR for this, can we get this PR merged #207 https://github.com/rancher/system-upgrade-controller/pull/215/files

@rajivml rajivml changed the title Pod Selector as a parameter to the drain command PodSelector and ignore-errors as a parameter to the drain command Jan 6, 2023
@jstewart612
Copy link

jstewart612 commented Apr 8, 2023

This was added in a commit two weeks ago or so: #231 which looks like it will go out in the 0.11.0 release.

You can try the dev1 prerelease if you're feeling lucky :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants