You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
When one (or more) upgrade job fails, the Plan status does not reflect a failure in the upgrade process.
Describe the solution you'd like
The Plan status should indicate that a failure in the upgrade process occured by at least updating the status.condtions.type and status.condtions.reason fields. This would ease tracking down a failure in the node upgrade process
Describe alternatives you've considered
Of course, getting the status of the jobs is a way to have information, but given that the Plan is driving these jobs, having this information in its status as well would be a nice addition.
Additional context
To reproduce, simply add the following plan that forces the job to fail (also, set the SYSTEM_UPGRADE_JOB_BACKOFF_LIMIT env var in the configmap to a low value like 2 to avoid waiting forever):
There is no clear indication of a failure whatsoever. Setting the fields reason and type (and maybe other custom fields like the job name) to reflect a failure would be nice.
Thanks
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
When one (or more) upgrade job fails, the Plan status does not reflect a failure in the upgrade process.
Describe the solution you'd like
The Plan status should indicate that a failure in the upgrade process occured by at least updating the
status.condtions.type
andstatus.condtions.reason
fields. This would ease tracking down a failure in the node upgrade processDescribe alternatives you've considered
Of course, getting the status of the jobs is a way to have information, but given that the Plan is driving these jobs, having this information in its status as well would be a nice addition.
Additional context
To reproduce, simply add the following plan that forces the job to fail (also, set the
SYSTEM_UPGRADE_JOB_BACKOFF_LIMIT
env var in the configmap to a low value like 2 to avoid waiting forever):After the retries, the job ends up in a failed state while the Plan status shows the following:
There is no clear indication of a failure whatsoever. Setting the fields
reason
andtype
(and maybe other custom fields like the job name) to reflect a failure would be nice.Thanks
The text was updated successfully, but these errors were encountered: