Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting ed25519 ssh key as user_public_key_path will fail to ssh into nodes - causes a problem when node requires elliptic key #96

Open
slickwarren opened this issue Dec 19, 2022 · 0 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@slickwarren
Copy link
Contributor

see https://github.com/rancherlabs/corral/blob/main/cmd/create.go#L358 for what I've found to be the culprit; tldr we expect the user to have an rsa key set, however some OS require an elliptic key (and others require an rsa key, like windows). We should have this function be dynamic enough to handle both rsa and elliptic keys

@jakefhyde jakefhyde self-assigned this Dec 20, 2022
@jakefhyde jakefhyde added this to the v1.2.0 milestone Dec 20, 2022
@jakefhyde jakefhyde added bug Something isn't working good first issue Good for newcomers labels Dec 20, 2022
@jakefhyde jakefhyde assigned slickwarren and unassigned jakefhyde Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants