Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to Have Even More Lights From Default? #3

Open
FriendlyGamer opened this issue Jul 1, 2021 · 4 comments
Open

Possible to Have Even More Lights From Default? #3

FriendlyGamer opened this issue Jul 1, 2021 · 4 comments

Comments

@FriendlyGamer
Copy link

Hiya there! I hope this finds you well!

But I am pondering, is it possible for us to have other full block lighting options, like for other bricks, planks and such from the game's Default "mod"?

So that buildings can be more ingrained and such?

Do let me know if this is possible and thanks in advance!

@random-geek
Copy link
Owner

Hi! Sorry for the belated response (as is typical for me :P).

Adding more lights based on existing nodes is certainly possible, but I'm reluctant to do it for a few reasons:

  1. Inventory clutter/loading times. One of the main goals of Morelights is to be fairly lightweight and fast. The more nodes I add, the longer it will take for clients to load the mod. I also don't want to gum up the crafting guide/creative menu with a lot of similar lighting nodes.
  2. Support for a variety of games. The Minetest developers want users to explore games beyond Minetest Game, and I have tried to assist that effort by supporting MineClone 2 and making it easier to add more games in the future. Grass, stone block and sandstone block lights all use the current game's native nodes/textures. Other games may not have these nodes, though, which would make crafting recipes and textures for these nodes more challenging.
  3. The "slippery slope." Once I add a wood plank light, then the mod would really need lights for all the types of wood planks, etc.

There are a couple other options. One is to add a "light placer" tool, allowing the player to add lights to any supported node; again, this would require registering more nodes and could create confusion. Another option is to add a similar lighting node that would be fairly flush with the node and could be placed anywhere. Unfortunately, this would make it impossible to place another node on the same surface.

Perhaps I could add a couple more nodes, but I'm very hesitant at the moment.

@FriendlyGamer
Copy link
Author

Hi! Sorry for the belated response (as is typical for me :P).

That's okay, thanks you for letting me aware of this and this is just perfectly typical for you. :)

Perhaps I could add a couple more nodes, but I'm very hesitant at the moment.

I understand, thank you for caring to explain to me on why you are very hesitant to do it, at least at this point in time.

@doxygen-spammer
Copy link
Contributor

The LinuxForks fork of this mod (https://github.com/h-v-smacker/morelights) has additional block lights similar to the existing grass light and stone tile light.

  • Dry grass
  • Gray dirt (from Ethereal mod)
  • Grove dirt (from Ethereal mod)
  • Desert stone block
  • Sandstone block
  • Desert sandstone block
  • Silver sandstone block
  • Obsidian block

To keep this mod lean, would you accept if I add a function that returns a node definition for arbitrary block lights? Then anyone can add their own block lights easily.

@random-geek
Copy link
Owner

To keep this mod lean, would you accept if I add a function that returns a node definition for arbitrary block lights? Then anyone can add their own block lights easily.

I don't see a reason not to, but it might not save that many lines of code. I'd at least consider such a function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants