Skip to content

Commit

Permalink
Fix a11y issues. Added signing keys.
Browse files Browse the repository at this point in the history
  • Loading branch information
nienow committed Jan 9, 2024
1 parent 7f394f6 commit 296702a
Show file tree
Hide file tree
Showing 6 changed files with 55 additions and 5 deletions.
23 changes: 23 additions & 0 deletions .idea/deploymentTargetDropDown.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .idea/misc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 17 additions & 3 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,23 @@ android {
namespace = "dev.randombits.intervaltimer"
compileSdk = 33

signingConfigs {
create("release") {
if (findProperty("PLAY_STORE_KEY") != null) {
storeFile = file(findProperty("PLAY_STORE_KEY") as String)
storePassword = findProperty("PLAY_STORE_PASSWORD") as String?
keyAlias = findProperty("PLAY_STORE_KEY_ALIAS") as String?
keyPassword = findProperty("PLAY_STORE_KEY_PASSWORD") as String?
}
}
}

defaultConfig {
applicationId = "dev.randombits.intervaltimer"
minSdk = 24
targetSdk = 33
versionCode = 1
versionName = "1.0"
versionCode = 3
versionName = "1.0.2"

vectorDrawables {
useSupportLibrary = true
Expand All @@ -21,8 +32,11 @@ android {

buildTypes {
release {
isMinifyEnabled = false
isMinifyEnabled = true
proguardFiles(getDefaultProguardFile("proguard-android-optimize.txt"), "proguard-rules.pro")
if (findProperty("PLAY_STORE_KEY") != null) {
signingConfig = signingConfigs.getByName("release")
}
}
}
compileOptions {
Expand Down
5 changes: 5 additions & 0 deletions app/src/main/res/layout/fragment_settings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:src="@drawable/minus"
android:contentDescription="@string/decrease_active_time"
android:scaleType="fitCenter" android:padding="16dp"/>

<EditText
Expand All @@ -40,6 +41,7 @@
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:src="@drawable/add_24"
android:contentDescription="@string/increase_active_time"
android:scaleType="fitCenter" android:padding="16dp"/>
</LinearLayout>
<TextView
Expand All @@ -58,6 +60,7 @@
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:src="@drawable/minus"
android:contentDescription="@string/decrease_rest_time"
android:scaleType="fitCenter" android:padding="16dp"/>

<EditText
Expand All @@ -74,6 +77,7 @@
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:src="@drawable/add_24"
android:contentDescription="@string/increase_rest_time"
android:scaleType="fitCenter" android:padding="16dp"/>
</LinearLayout>

Expand All @@ -83,5 +87,6 @@
android:layout_width="100dp"
android:layout_height="100dp"
android:layout_gravity="center"
android:contentDescription="@string/btn_start"
android:background="@drawable/play_circle_120"/>
</LinearLayout>
3 changes: 3 additions & 0 deletions app/src/main/res/layout/fragment_timer.xml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
android:layout_width="100dp"
android:layout_height="100dp"
android:layout_gravity="center"
android:contentDescription="@string/btn_pause"
android:background="@drawable/pause_circle_120"/>

<Button
Expand All @@ -56,6 +57,7 @@
android:layout_width="100dp"
android:layout_height="100dp"
android:layout_gravity="center"
android:contentDescription="@string/btn_resume"
android:background="@drawable/play_circle_120"/>

<Button
Expand All @@ -64,6 +66,7 @@
android:layout_width="100dp"
android:layout_height="100dp"
android:layout_gravity="center"
android:contentDescription="@string/btn_stop"
android:background="@drawable/stop_circle_120"/>
</LinearLayout>

Expand Down
7 changes: 6 additions & 1 deletion app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,15 @@
<string name="app_title">Interval Timer</string>
<string name="activeTime_label">Active</string>
<string name="restTime_label">Rest</string>
<string name="btn_start">Prepare</string>
<string name="btn_settings">Settings</string>
<string name="btn_start">Start</string>
<string name="btn_pause">Pause</string>
<string name="btn_stop">Stop</string>
<string name="btn_resume">Resume</string>
<string name="setCount">%1$d</string>
<string name="set">SET</string>
<string name="decrease_active_time">Decrease Active Time</string>
<string name="increase_active_time">Increase Active Time</string>
<string name="decrease_rest_time">Decrease Rest Time</string>
<string name="increase_rest_time">Increase Rest Time</string>
</resources>

0 comments on commit 296702a

Please sign in to comment.