From 45872ed6b2054af9df579cac1174555067445d9d Mon Sep 17 00:00:00 2001 From: Elminson De Oleo Baez Date: Wed, 18 Jul 2018 17:02:25 -0400 Subject: [PATCH] comment conf file (#160) * Creating a array that content all the patterns used in the class, this allow if in the feature we want to create a new featured that include patterns we cant add this for a best readeability (some patterns get really complicated * Modifying all the sugestion from rap2hpoutre in the PR comments * Log Location customisable #139 * changing storage_path() to ->storage_path * Fixing error Cannot use object of type Rap2hpoutre\LaravelLogViewer\Pattern as array + changing array to not static + creating new function getPattern * fixing Codacy/PR Quality Review * Adding .idea to gitignore file + adding comments to config file Merge remote-tracking branch 'upstream/master' # Conflicts: # src/Rap2hpoutre/LaravelLogViewer/LaravelLogViewer.php # src/Rap2hpoutre/LaravelLogViewer/Pattern.php --- .gitignore | 1 + src/Rap2hpoutre/LaravelLogViewer/Pattern.php | 1 - src/config/logviewer.php | 8 ++++++++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 8b7ef35..e8f94b7 100644 --- a/.gitignore +++ b/.gitignore @@ -1,2 +1,3 @@ /vendor composer.lock +/.idea diff --git a/src/Rap2hpoutre/LaravelLogViewer/Pattern.php b/src/Rap2hpoutre/LaravelLogViewer/Pattern.php index 202e755..bba96fe 100644 --- a/src/Rap2hpoutre/LaravelLogViewer/Pattern.php +++ b/src/Rap2hpoutre/LaravelLogViewer/Pattern.php @@ -44,5 +44,4 @@ public function getPattern($pattern, $position = null) return $this->patterns[$pattern]; } - } diff --git a/src/config/logviewer.php b/src/config/logviewer.php index 0e4ead5..d8183d7 100644 --- a/src/config/logviewer.php +++ b/src/config/logviewer.php @@ -1,6 +1,14 @@ env('LOGVIEWER_PATTERN', '*.log'), 'storage_path' => env('LOGVIEWER_STORAGE_PATH', 'logs'), ];