-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FinTS3Client._touchdown... attributes missing after restoring client #125
Comments
That's probably the easiest solution, although it's probably not easy to store the lambda. I'm not sure if it would be theoretically better to store the information in NeedRetryResponse.from_data instead and reconstruct from there. The latter might make more sense if it is allowed to do a different operation "in-between". NeedRetryResponse would kinda need to know which operation it belongs to (HKKAZ in this case) and then send_tan could initialize the touchpoint state based on that information |
Quite pragmatic, but what do you think of this solution just before return statement in send_tan
Any idea of using less hardcoding or maybe have a more flexible way of handling operations, ...? |
...and we need to do that for all operations? Maybe it could be centralized somewhere? for get_transactions_xml it seems to be:
|
Hi, Nevertheless, the outlined workaround seems to work for me after slightly modifying it.
Thanks, |
Maybe! It would require either
I don't remember running into this when I tested the implementation with my banks, but I'm not sure. |
Describe the bug
For getting older transactions from Skatbank and comdirect there is a TAN needed. I need to pause dialogue, deconstruct client (including private data) and store request. After restoring/resuming and sending TAN there is an exception in
_continue_fetch_with_touchdowns
, because self._touchdown_args (amonst others) is not set.TAN seems to be processed already correctly and accepted by bank.
Bank I tested this with
Name of the bank: comdirect (using PhotoTAN)
FinTS URL: https://fints.comdirect.de/fints
Name of the bank: Skatbank (using VR-SecureGo (Push TAN))
FinTS URL: https://hbci11.fiducia.de/cgi-bin/hbciservlet
Expected behavior
After sending TAN it should return requested transactions
Code required to reproduce
(copied from https://python-fints.readthedocs.io/en/latest/trouble.html)
Log output / error message
Solution / Quick hack
After setting the missing attributes in
ask_for_tan
beforef.send_tan
- it works: (just some dirty copy paste from_fetch_with_touchdowns
andget_transactions
)I think it needs to be saved in
deconstruct
and restored inset_data
?The text was updated successfully, but these errors were encountered: