Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

margin and padding for View #118

Open
raphamorim opened this issue Jun 8, 2022 · 8 comments
Open

margin and padding for View #118

raphamorim opened this issue Jun 8, 2022 · 8 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@raphamorim
Copy link
Owner

Implementation of margin and padding for existent elements

@raphamorim raphamorim added enhancement New feature or request help wanted Extra attention is needed labels Jun 8, 2022
@raphamorim raphamorim added this to the 0.2.0 milestone Jun 8, 2022
@Harshalyadav
Copy link

May, I take this issue?

@raphamorim
Copy link
Owner Author

raphamorim commented Jun 8, 2022

For sure, feel free to take it @Harshalyadav but please start with one, breaking in three PRs: image, text, view (the order you take doesn’t matter)

@raphamorim raphamorim changed the title margin and padding for View, Image and Text margin and padding for View Jun 9, 2022
@raphamorim
Copy link
Owner Author

@Harshalyadav I have broken into smaller issues (View, Text and Image). Later let me know which one want to work on, so I can assign the issue to you :)

@Harshalyadav
Copy link

Could you give me more info about this issue?

@raphamorim
Copy link
Owner Author

Yes, so the goal is to have the Style Props working for View. Both style props, margin and padding, follow React Native same directives and the work it works. Which is inspired by the way it works on CSS in Web browsers (https://blog.hubspot.com/website/css-margin-vs-padding).

@AAYUSH-droid
Copy link

hey u distributed this issue among #118 #119 #120?

@raphamorim
Copy link
Owner Author

yup @AAYUSH-droid

@Harshalyadav
Copy link

@raphamorim, Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
No open projects
Development

No branches or pull requests

3 participants