Skip to content

Commit

Permalink
Replace local copyright check with pre-commit-hooks verify-copyright (#…
Browse files Browse the repository at this point in the history
…14917)

The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Jake Awe (https://github.com/AyodeAwe)
  - Karthikeyan (https://github.com/karthikeyann)
  - Lawrence Mitchell (https://github.com/wence-)

URL: #14917
  • Loading branch information
KyleFromNVIDIA authored Mar 4, 2024
1 parent da11301 commit 0ff5a2c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 283 deletions.
13 changes: 7 additions & 6 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -126,12 +126,6 @@ repos:
- cmakelang==0.6.13
verbose: true
require_serial: true
- id: copyright-check
name: copyright-check
entry: python ./ci/checks/copyright.py --git-modified-only --update-current-year
language: python
pass_filenames: false
additional_dependencies: [gitpython]
- id: doxygen-check
name: doxygen-check
entry: ./ci/checks/doxygen.sh
Expand Down Expand Up @@ -161,6 +155,13 @@ repos:
hooks:
- id: ruff
files: python/.*$
- repo: https://github.com/rapidsai/pre-commit-hooks
rev: v0.0.1
hooks:
- id: verify-copyright
exclude: |
(?x)
cpp/include/cudf_test/cxxopts[.]hpp$
default_language_version:
Expand Down
277 changes: 0 additions & 277 deletions ci/checks/copyright.py

This file was deleted.

0 comments on commit 0ff5a2c

Please sign in to comment.