Skip to content

Commit

Permalink
Update kvikio call due to upstream changes (#17733)
Browse files Browse the repository at this point in the history
KvikIO has just introduced slightly breaking code changes (rapidsai/kvikio#581) where the utility function `getenv_or` is moved out of the `detail` namespace and becomes part of the public API. This PR adapts cuDF for this change.

This PR has been tested locally using the abovementioned KvikIO branch.

Authors:
  - Tianyu Liu (https://github.com/kingcrimsontianyu)
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Devavret Makkar (https://github.com/devavret)
  - Bradley Dice (https://github.com/bdice)
  - Muhammad Haseeb (https://github.com/mhaseeb123)

URL: #17733
  • Loading branch information
kingcrimsontianyu authored Jan 14, 2025
1 parent 8470291 commit fe75cb8
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions cpp/src/io/utilities/config_utils.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2021-2024, NVIDIA CORPORATION.
* Copyright (c) 2021-2025, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -56,8 +56,7 @@ void set_up_kvikio()
{
static std::once_flag flag{};
std::call_once(flag, [] {
auto const compat_mode =
kvikio::detail::getenv_or("KVIKIO_COMPAT_MODE", kvikio::CompatMode::ON);
auto const compat_mode = kvikio::getenv_or("KVIKIO_COMPAT_MODE", kvikio::CompatMode::ON);
kvikio::defaults::compat_mode_reset(compat_mode);

auto const nthreads = getenv_or<unsigned int>("KVIKIO_NTHREADS", 4u);
Expand Down

0 comments on commit fe75cb8

Please sign in to comment.