Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate and optimize integer power implementations in libcudf #14243

Open
bdice opened this issue Oct 3, 2023 · 0 comments
Open

Consolidate and optimize integer power implementations in libcudf #14243

bdice opened this issue Oct 3, 2023 · 0 comments
Assignees
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.

Comments

@bdice
Copy link
Contributor

bdice commented Oct 3, 2023

Recently, some issues were identified where std::pow was being used with fixed-point values (#14210, #14233, #14242). There are many places in libcudf where we require an "integer power" operator, because std::pow uses floating-point values and thus gives erroneous results when handling high-precision integral values like decimal128. This thread covers a few key changes that are needed in libcudf:

Related: #10178

@bdice bdice added feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. tech debt labels Oct 3, 2023
@bdice bdice self-assigned this Oct 3, 2023
raydouglass pushed a commit that referenced this issue Oct 3, 2023
…nt values. (#14242)

This is a follow-up PR to #14233. This PR fixes a bug where floating-point values were used as intermediates in ceil/floor unary operations and cast operations that require rescaling for fixed-point types, giving inaccurate results.

See also:
- #14233 (comment)
- #14243

Authors:
   - Bradley Dice (https://github.com/bdice)

Approvers:
   - Mike Wilson (https://github.com/hyperbolic2346)
   - Vukasin Milovanovic (https://github.com/vuule)
@vyasr vyasr removed the tech debt label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

No branches or pull requests

2 participants