Skip to content

Commit

Permalink
Use GCC 13 in CUDA 12 conda builds. (#108)
Browse files Browse the repository at this point in the history
conda-forge is using GCC 13 for CUDA 12 builds. This PR updates CUDA 12 conda builds to use GCC 13, for alignment.

These PRs should be merged in a specific order, see rapidsai/build-planning#129 for details.

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #108
  • Loading branch information
bdice authored Jan 17, 2025
1 parent d38b832 commit a076b51
Show file tree
Hide file tree
Showing 8 changed files with 34 additions and 40 deletions.
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-121_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ dependencies:
- dask-cudf==25.2.*,>=0.0.0a0
- dglteam/label/th23_cu121::dgl>=2.4.0.th23.cu*
- doxygen
- gcc_linux-64=11.*
- gcc_linux-64=13.*
- graphviz
- ipython
- libcublas-dev
Expand Down
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-124_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ dependencies:
- dask-cudf==25.2.*,>=0.0.0a0
- dglteam/label/th23_cu121::dgl>=2.4.0.th23.cu*
- doxygen
- gcc_linux-64=11.*
- gcc_linux-64=13.*
- graphviz
- ipython
- libcublas-dev
Expand Down
8 changes: 5 additions & 3 deletions conda/recipes/cugraph-pyg/conda_build_config.yaml
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
# Copyright (c) 2022, NVIDIA CORPORATION.

c_compiler_version:
- 11
- 13 # [not os.environ.get("RAPIDS_CUDA_VERSION", "").startswith("11")]
- 11 # [os.environ.get("RAPIDS_CUDA_VERSION", "").startswith("11")]

cxx_compiler_version:
- 11
- 13 # [not os.environ.get("RAPIDS_CUDA_VERSION", "").startswith("11")]
- 11 # [os.environ.get("RAPIDS_CUDA_VERSION", "").startswith("11")]

cuda_compiler:
- nvcc
Expand All @@ -16,4 +18,4 @@ c_stdlib:
- sysroot

c_stdlib_version:
- "2.17"
- "2.28"
14 changes: 7 additions & 7 deletions conda/recipes/libwholegraph/conda_build_config.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
c_compiler_version:
- 11
- 13 # [not os.environ.get("RAPIDS_CUDA_VERSION", "").startswith("11")]
- 11 # [os.environ.get("RAPIDS_CUDA_VERSION", "").startswith("11")]

cxx_compiler_version:
- 11
- 13 # [not os.environ.get("RAPIDS_CUDA_VERSION", "").startswith("11")]
- 11 # [os.environ.get("RAPIDS_CUDA_VERSION", "").startswith("11")]

cuda_compiler:
- cuda-nvcc

cuda11_compiler:
- nvcc
- cuda-nvcc # [not os.environ.get("RAPIDS_CUDA_VERSION", "").startswith("11")]
- nvcc # [os.environ.get("RAPIDS_CUDA_VERSION", "").startswith("11")]

cmake_version:
- ">=3.26.4,!=3.30.0"
Expand All @@ -23,4 +23,4 @@ c_stdlib:
- sysroot

c_stdlib_version:
- "2.17"
- "2.28"
12 changes: 4 additions & 8 deletions conda/recipes/libwholegraph/meta.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2019-2024, NVIDIA CORPORATION.
# Copyright (c) 2019-2025, NVIDIA CORPORATION.

{% set version = environ['RAPIDS_PACKAGE_VERSION'].lstrip('v') + environ.get('VERSION_SUFFIX', '') %}
{% set minor_version = version.split('.')[0] + '.' + version.split('.')[1] %}
Expand Down Expand Up @@ -42,7 +42,7 @@ requirements:
- {{ compiler('c') }}
- {{ compiler('cxx') }}
{% if cuda_major == "11" %}
- {{ compiler('cuda11') }} ={{ cuda_version }}
- {{ compiler('cuda') }} ={{ cuda_version }}
{% else %}
- {{ compiler('cuda') }}
{% endif %}
Expand Down Expand Up @@ -74,10 +74,8 @@ outputs:
number: {{ GIT_DESCRIBE_NUMBER }}
string: cuda{{ cuda_major }}_{{ date_string }}_{{ GIT_DESCRIBE_HASH }}_{{ GIT_DESCRIBE_NUMBER }}
ignore_run_exports_from:
{% if cuda_major == "11" %}
- {{ compiler('cuda11') }}
{% else %}
- {{ compiler('cuda') }}
{% if cuda_major != "11" %}
- cuda-cudart-dev
{% endif %}
requirements:
Expand Down Expand Up @@ -110,10 +108,8 @@ outputs:
number: {{ GIT_DESCRIBE_NUMBER }}
string: cuda{{ cuda_major }}_{{ date_string }}_{{ GIT_DESCRIBE_HASH }}_{{ GIT_DESCRIBE_NUMBER }}
ignore_run_exports_from:
{% if cuda_major == "11" %}
- {{ compiler('cuda11') }}
{% else %}
- {{ compiler('cuda') }}
{% if cuda_major != "11" %}
- cuda-cudart-dev
{% endif %}
requirements:
Expand Down
14 changes: 7 additions & 7 deletions conda/recipes/pylibwholegraph/conda_build_config.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
c_compiler_version:
- 11
- 13 # [not os.environ.get("RAPIDS_CUDA_VERSION", "").startswith("11")]
- 11 # [os.environ.get("RAPIDS_CUDA_VERSION", "").startswith("11")]

cxx_compiler_version:
- 11
- 13 # [not os.environ.get("RAPIDS_CUDA_VERSION", "").startswith("11")]
- 11 # [os.environ.get("RAPIDS_CUDA_VERSION", "").startswith("11")]

cuda_compiler:
- cuda-nvcc

cuda11_compiler:
- nvcc
- cuda-nvcc # [not os.environ.get("RAPIDS_CUDA_VERSION", "").startswith("11")]
- nvcc # [os.environ.get("RAPIDS_CUDA_VERSION", "").startswith("11")]

cmake_version:
- ">=3.26.4,!=3.30.0"
Expand All @@ -20,4 +20,4 @@ c_stdlib:
- sysroot

c_stdlib_version:
- "2.17"
- "2.28"
6 changes: 1 addition & 5 deletions conda/recipes/pylibwholegraph/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,14 @@ build:
- SCCACHE_S3_USE_SSL
- SCCACHE_S3_NO_CREDENTIALS
ignore_run_exports_from:
{% if cuda_major == "11" %}
- {{ compiler('cuda11') }}
{% else %}
- {{ compiler('cuda') }}
{% endif %}

requirements:
build:
- {{ compiler('c') }}
- {{ compiler('cxx') }}
{% if cuda_major == "11" %}
- {{ compiler('cuda11') }} ={{ cuda_version }}
- {{ compiler('cuda') }} ={{ cuda_version }}
{% else %}
- {{ compiler('cuda') }}
{% endif %}
Expand Down
16 changes: 8 additions & 8 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -260,27 +260,27 @@ dependencies:
matrices:
- matrix:
arch: x86_64
cuda: "11.8"
packages:
- gcc_linux-64=11.*
- nvcc_linux-64=11.8
- matrix:
arch: aarch64
cuda: "11.8"
packages:
- gcc_linux-aarch64=11.*
- output_types: [conda]
matrices:
- nvcc_linux-aarch64=11.8
- matrix:
arch: x86_64
cuda: "11.8"
cuda: "12.*"
packages:
- nvcc_linux-64=11.8
- gcc_linux-64=13.*
- cuda-nvcc
- matrix:
arch: aarch64
cuda: "11.8"
packages:
- nvcc_linux-aarch64=11.8
- matrix:
cuda: "12.*"
packages:
- gcc_linux-aarch64=13.*
- cuda-nvcc

docs:
Expand Down

0 comments on commit a076b51

Please sign in to comment.