Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove reliance on remote datasets in tests #650

Open
jameslamb opened this issue Jan 28, 2025 · 0 comments
Open

remove reliance on remote datasets in tests #650

jameslamb opened this issue Jan 28, 2025 · 0 comments

Comments

@jameslamb
Copy link
Member

jameslamb commented Jan 28, 2025

Description

One test here downloads a file from a non-RAPIDS repo (https://github.com/loganpowell/census-geojson) on every run:

choropleth3d_chart = charts.choropleth(
x="states",
color_column="val",
elevation_column="val_t",
color_aggregate_fn="mean",
elevation_aggregate_fn="count",
add_interaction=False,
elevation_factor=100000,
geoJSONSource=(
"https://raw.githubusercontent.com/loganpowell/census-geojson"
"/master/GeoJSON/5m/2018/state.json"
),
geoJSONProperty="STATEFP",
map_style="testMap",
)

That should be factored out.

Benefits of this work

Acceptance Criteria

  • tests do not depend on downloading external data (where avoidable)

Approach

Some possible alternatives:

  • using synthetic geojson data generated at test time
  • using test data checked into source control here (ideally a smaller file, if appropriate... that file is 2.1MB)
  • removing the test (if on a re-review, it seems to not be useful)

Notes

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant