From d565a17f0c255eca5b9d3d8493fb26d2c77aedc1 Mon Sep 17 00:00:00 2001 From: James Lamb Date: Thu, 11 Jan 2024 09:37:50 -0600 Subject: [PATCH] refactor CUDA versions in dependencies.yaml (#1303) Contributes to https://github.com/rapidsai/build-planning/issues/7. Proposes splitting the `cuda-version` dependency in `dependencies.yaml` out to its own thing, separate from the bits of the CUDA Toolkit this project needs. ### Benefits of this change * prevents accidental inclusion of multiple `cuda-version` version in environments * reduces update effort (via enabling more use of globs like `"12.*"`) * improves the chance that errors like "`conda` recipe is missing a dependency" are caught in CI Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) - Peter Andreas Entschev (https://github.com/pentschev) - Ray Douglass (https://github.com/raydouglass) URL: https://github.com/rapidsai/dask-cuda/pull/1303 --- .pre-commit-config.yaml | 2 +- dependencies.yaml | 30 ++++++++++++++++++------------ 2 files changed, 19 insertions(+), 13 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 724b2ad1d..492c96f2c 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -33,7 +33,7 @@ repos: args: ["--module=dask_cuda", "--ignore-missing-imports"] pass_filenames: false - repo: https://github.com/rapidsai/dependency-file-generator - rev: v1.5.1 + rev: v1.8.0 hooks: - id: rapids-dependency-file-generator args: ["--clean"] diff --git a/dependencies.yaml b/dependencies.yaml index 77546b97f..eb7148615 100644 --- a/dependencies.yaml +++ b/dependencies.yaml @@ -7,7 +7,8 @@ files: arch: [x86_64] includes: - build_python - - cudatoolkit + - cuda + - cuda_version - develop - docs - py_version @@ -16,7 +17,8 @@ files: test_python: output: none includes: - - cudatoolkit + - cuda + - cuda_version - py_version - test_python checks: @@ -27,7 +29,8 @@ files: docs: output: none includes: - - cudatoolkit + - cuda + - cuda_version - docs - py_version py_build: @@ -75,34 +78,37 @@ dependencies: - output_types: pyproject packages: - tomli ; python_version < '3.11' - cudatoolkit: + cuda_version: specific: - output_types: conda matrices: - - matrix: - cuda: "11.2" - packages: - - cuda-version=11.2 - - cudatoolkit - matrix: cuda: "11.4" packages: - cuda-version=11.4 - - cudatoolkit - matrix: cuda: "11.5" packages: - cuda-version=11.5 - - cudatoolkit - matrix: cuda: "11.8" packages: - cuda-version=11.8 - - cudatoolkit - matrix: cuda: "12.0" packages: - cuda-version=12.0 + cuda: + specific: + - output_types: conda + matrices: + - matrix: + cuda: "11.*" + packages: + - cudatoolkit + - matrix: + cuda: "12.*" + packages: - cuda-nvcc-impl - cuda-nvrtc develop: