Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow test.yaml jobs to use the latest branch build if it is more recent than the latest nightly build #138

Open
vyasr opened this issue Feb 3, 2025 · 4 comments
Assignees

Comments

@vyasr
Copy link
Contributor

vyasr commented Feb 3, 2025

Currently all our test CI jobs use rapids-download-*-from-s3 to get their artifacts (cudf example). These tools all call rapids-download-from-s3, which in turn calls rapids-s3-path. Since rapids-s3-path constructs its path based on the build type, that implicitly means that test.yaml always pulls the build from the corresponding nightly build, even if there was a more recent branch build. This is particularly problematic in light of rapidsai/build-planning#127 since it is now more important to be able to resolve these failures within a given day i.e. by rerunning the test workflow on a branch build. To support this use case, we should make the build type an optional input to the test.yaml workflow to customize which type of build to pull in the workflow. This will allow us to customize running a test workflow on a branch build to unblock CI once fixes are in.

@bdice
Copy link
Contributor

bdice commented Feb 3, 2025

Our build workflows have three options: nightly, pull-request, and branch.

Our test workflows only accept nightly and pull-request as options, so we'd need a third option for branch tests in places like these:

https://github.com/rapidsai/shared-workflows/blob/6b1b82739d30ca3da0335a45722cef8380874241/.github/workflows/conda-cpp-tests.yaml#L53-L58

Then, we should make build_type a configurable input to test.yaml in each repository. The default should be nightly, same as our build workflows, but we need to be able to set build_type: branch in manually triggered runs.

@gforsyth
Copy link
Contributor

gforsyth commented Feb 3, 2025

I'm targeting the 25.04 for this, but if it would get some 25.02 stuff unblocked I can retarget

@bdice
Copy link
Contributor

bdice commented Feb 4, 2025

I'm targeting the 25.04 for this, but if it would get some 25.02 stuff unblocked I can retarget

25.04 should be fine.

@vyasr
Copy link
Contributor Author

vyasr commented Feb 4, 2025

Agreed it isn't 25.02 urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants