Use keyword args only for models. Small change to callback.

rapidsai · Feb 13, 2025 · 2616e78 · 2616e78
1 parent 4c15ea3
commit 2616e78
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 2 deletions.
diff --git a/legateboost/legateboost.py b/legateboost/legateboost.py
@@ -294,10 +294,10 @@ def _partial_fit(
 
             # callbacks after iteration
             if any(
-                (
+                [
                     c.after_iteration(self, model_idx, eval_result)
                     for c in self.callbacks
-                )
+                ]
             ):
                 break
 

diff --git a/legateboost/models/krr.py b/legateboost/models/krr.py
@@ -83,6 +83,7 @@ class KRR(BaseModel):
 
     def __init__(
         self,
+        *,
         n_components: int = 100,
         alpha: Any = "deprecated",
         l2_regularization: float = 1e-5,

diff --git a/legateboost/models/linear.py b/legateboost/models/linear.py
@@ -41,6 +41,7 @@ class Linear(BaseModel):
 
     def __init__(
         self,
+        *,
         l2_regularization: float = 1e-5,
         alpha: Any = "deprecated",
         solver: str = "direct",

diff --git a/legateboost/models/nn.py b/legateboost/models/nn.py
@@ -33,6 +33,7 @@ class NN(BaseModel):
 
     def __init__(
         self,
+        *,
         max_iter: int = 100,
         hidden_layer_sizes: Tuple[int] = (100,),
         alpha: Any = "deprecated",

diff --git a/legateboost/models/tree.py b/legateboost/models/tree.py
@@ -54,6 +54,7 @@ class Tree(BaseModel):
 
     def __init__(
         self,
+        *,
         max_depth: int = 8,
         split_samples: int = 256,
         l1_regularization: float = 0.0,
-Original file line number
+Diff line change
@@ Expand Up / @@ -294,10 +294,10 @@ def _partial_fit( @@
                 # callbacks after iteration
                 if any(
-                    (
+                    [
                         c.after_iteration(self, model_idx, eval_result)
                         for c in self.callbacks
-                    )
+                    ]
                 ):
                     break
@@ Expand Down @@