-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI installed version to not include commit offset #5
Comments
Suspect this was copied from an old I think it's referring to this: legate-raft/ci/test_python_common.sh Lines 16 to 17 in 4f0afc1
Lines 9 to 10 in 4f0afc1
Some notes:
rapids-generate-version > ./VERSION
LEGATEBOOST_VERSION=$(rapids-version) (legate-boost/ci/test_python_common.sh) That has its own risks ... it could silently fall back to something else published on the |
I thought that changing:
in the docs build and test scripts when installing was a good idea to make things strict, but it seems like it is not actually safe (as noted by @jameslamb).
So, I should change it back (possibly also in one place in legate-dataframe).
A bit unclear if we need to build the
.dev<N>
version at all in that case, but maybe it is nice to just do it anyway.The text was updated successfully, but these errors were encountered: