Merge pull request vimeo#10360 from robchett/remove_early_progress_wh…

…en_scanning_partial_codebase A segment of progress was being output early as the startScanningFile…
rarila · Nov 13, 2023 · 5095f4e · 5095f4e
2 parents bb4d808 + f4aef37
commit 5095f4e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Psalm/Internal/Analyzer/ProjectAnalyzer.php b/src/Psalm/Internal/Analyzer/ProjectAnalyzer.php
@@ -1050,6 +1050,9 @@ public function checkFile(string $file_path): void
      */
     public function checkPaths(array $paths_to_check): void
     {
+        $this->progress->write($this->generatePHPVersionMessage());
+        $this->progress->startScanningFiles();
+
         $this->config->visitPreloadedStubFiles($this->codebase, $this->progress);
         $this->visitAutoloadFiles();
 
@@ -1069,9 +1072,6 @@ public function checkPaths(array $paths_to_check): void
 
         $this->file_reference_provider->loadReferenceCache();
 
-        $this->progress->write($this->generatePHPVersionMessage());
-        $this->progress->startScanningFiles();
-
         $this->config->initializePlugins($this);
 
 

diff --git a/src/Psalm/Progress/LongProgress.php b/src/Psalm/Progress/LongProgress.php
@@ -25,7 +25,7 @@ class LongProgress extends Progress
 
     protected bool $print_infos = false;
 
-    protected bool $fixed_size = true;
+    protected bool $fixed_size = false;
 
     public function __construct(bool $print_errors = true, bool $print_infos = true)
     {