Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Add spec for team CRUD endpoint #6

Merged
merged 3 commits into from
Apr 10, 2018

Conversation

aaronxsu
Copy link
Member

@aaronxsu aaronxsu commented Apr 4, 2018

This PR adds spec for team CRUD endpoint implemented in raster-foundry/raster-foundry#3127

This is a part of feature/platform-spec

Marked as WIP since there might be some clean up to do.

Closes #4

Copy link
Contributor

@alkamin alkamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one thing to add.

spec.yml Outdated
@@ -85,6 +85,13 @@ x-resources:
- name: Shapes
description: |
"Shapes are vectors that each user can create and manage. These shapes can then be used in various ways within the Raster Foundry platform."
- name: Licenses
description: |
"A license is an official permission or permit to do, use, or own something."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add something like "Users can add licenses to the data they create and share in Raster Foundry to communicate to others if and how that data can be used".

spec.yml Outdated
in: body
required: true
schema:
$ref: '#/definitions/Team'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should create a separate schema for team creation so that fields like createdAt, createdBy etc. don't show up in the spec as fields that can be set on creation. It would probably reflect the Team.Create case class in the API.

spec.yml Outdated
in: body
required: true
schema:
$ref: '#/definitions/Team'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also want to use a schema that better reflects the fields that the user can actually update. I'm sure we have other spots in this spec where we don't do this, but it's something that could be important if we want to move to spec based testing of the API.

@aaronxsu aaronxsu changed the title [WIP] Add spec for team CRUD endpoint Add spec for team CRUD endpoint Apr 6, 2018
Copy link
Contributor

@alkamin alkamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

spec.yml Outdated
@@ -85,6 +85,13 @@ x-resources:
- name: Shapes
description: |
"Shapes are vectors that each user can create and manage. These shapes can then be used in various ways within the Raster Foundry platform."
- name: Licenses
description: |
"A license is an official permission or permit to do, use, or own something." Users can add licenses to the data they create and share in Raster Foundry to communicate to others if and how that data can be used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quotes here don't enclose the whole blurb.

@aaronxsu aaronxsu merged commit 6e5cbd8 into feature/platform-spec Apr 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants