Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: registry store #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: registry store #30

wants to merge 1 commit into from
+894 −4

Conversation

shizhMSFT
Copy link
Contributor

@shizhMSFT shizhMSFT commented Jan 23, 2025 •
edited
Loading

What this PR does / why we need it:

Implement registry store based on ORAS.

Which issue(s) this PR resolves

Resolves #19

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.66055% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
registry_store.go 92.66% 7 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
registry_store.go 92.66% <92.66%> (ø)

@shizhMSFT shizhMSFT marked this pull request as ready for review January 24, 2025 08:36
shizhMSFT
shizhMSFT commented Jan 24, 2025
View reviewed changes
oci_store.go Outdated Show resolved Hide resolved
@shizhMSFT shizhMSFT mentioned this pull request Jan 24, 2025
Open
3 tasks
@shizhMSFT shizhMSFT force-pushed the registry_store branch 3 times, most recently from dfb469a to 36ceab6 Compare January 27, 2025 02:59
junczhu
junczhu reviewed Jan 27, 2025
View reviewed changes
registry_store.go

// repository returns a new remote repository for the given reference with the
// client set.
func (s RegistryStore) repository(ref string) (*remote.Repository, error) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we use pointer to RegistryStore here as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junczhu junczhu junczhu left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Oras Store
2 participants
@shizhMSFT @junczhu