feat: block screen [SGW-3617] #788
Conversation
Application
Storybook
|
| @@ -271,78 +272,88 @@ export const CollectCustomerDetailsScreen: FunctionComponent< | |||
|
|
|||
| const tCampaignName = c13nt(features?.campaignName ?? ""); | |||
|
|
|||
| const [shouldBlock, setShouldBlock] = useState(true); | |||
| useEffect(() => { | |||
There was a problem hiding this comment.
block for the first time when user navigates to CollectCustomerDetailsScreen (triggered by refreshing or after OTP)
Screen.Recording.2024-06-04.at.1.49.04.PM.mov
| const [shouldBlock, setShouldBlock] = useState(true); | ||
| useEffect(() => { | ||
| setShouldBlock(true); | ||
| }, []); | ||
|
|
There was a problem hiding this comment.
blocks when user navigates to login (AKA add new campaign)
Screen.Recording.2024-06-04.at.1.31.26.PM.mov
dalsontws
changed the title
| @@ -107,6 +109,8 @@ describe("CollectCustomerDetailsScreen", () => { | |||
| </CreateProvidersWrapper> | |||
| ); | |||
|
|
|||
| const continueAppButton = getByTestId(continueAppButtonId); | |||
There was a problem hiding this comment.
since this screen is blocked, all tests require additional button click to reach original screen
| @@ -77,11 +78,13 @@ describe("LoginContainer component tests", () => { | |||
| cleanup(); | |||
| }); | |||
|
|
|||
| it("should render LoginScanCard", () => { | |||
| it("should render LoginScanCard", async () => { | |||
There was a problem hiding this comment.
since this screen is blocked, all tests require additional button click to reach original screen
| // jest.advanceTimersByTime(29999); | ||
| // expect(queryByText("Resend")).toBeNull(); |
There was a problem hiding this comment.
some flakiness related to timer - infinite loop, looking into this
| const handleWebNavigation = (): void => { | ||
| Linking.openURL("https://app.supply.gov.sg"); | ||
| }; |
There was a problem hiding this comment.
Screen.Recording.2024-06-04.at.3.00.12.PM.mov
dalsontws
force-pushed
the
chore/block-screen
branch
from
31c9920 to
d0e7354
Compare
dalsontws
force-pushed
the
chore/block-screen
branch
from
d0e7354 to
b57c811
Compare
Notion link
This PR adds...
Screen.Recording.2024-06-04.at.2.33.41.PM.mov