This repository has been archived by the owner on Dec 3, 2024. It is now read-only.
Fix #10 #21
Open
Fix #10 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of the `kallithea_version` fact has been heavily inspired by the elasticsearch/elasticsearch module. The idea is to get the Kallithea version from the output of `pip version kallithea`. However, the problem is that the path to the pip binary of Kallitheas virtualenv depends on `$kallithea::install::venv`, which is unknown on the puppet client. Therefore, we first store this information on the Puppet client in `/etc/kallithea.yml` which enables us to read them later, when the `kallithea_version` fact needs to be evaluated. The concept of persisting interesting information on the client side seems to be so useful, that I have generalized this by means of the `settings_store` class and the `stored_setting` defined type. They are based on the richardc/datacat module, which allows us to merge the data given by multiple `stored_setting` declarations before they get written to `/etc/kallithea.yml`. refs #10
I realized that the pluginsync is disabled on `puppet apply` runs, thus our custom `kallithea_version` fact will not be available during beaker runs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A prototype for implementing #10. It still has some issues:
kallithea_versionfact is not tested (beaker doesn't do it, because pluginsync is disabled on puppet apply - maybe we could 'sync it by hand' during acceptance tests?/etc/kallithea.ymlis not idempotent - needs to be sorted somehow...