Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Text Fragments #293

Open
philrz opened this issue Mar 9, 2023 · 3 comments
Open

Add support for Text Fragments #293

philrz opened this issue Mar 9, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@philrz
Copy link

philrz commented Mar 9, 2023

A colleague of mine recently created a page with a link that used a Text Fragment. It looks like this concept has been around long enough that common browsers support it, but Muffet unfortunately chokes on it. An example:

$ muffet --version
2.7.0

$ muffet --verbose --one-page-only --buffer-size 8192 https://www.brimdata.io/blog/wrangling-json-arrays-with-zed/
https://www.brimdata.io/blog/wrangling-json-arrays-with-zed/
	200	https://buttons.github.io/buttons.js
...
	999	https://linkedin.com/company/brimdata
	id #:~:text=The nested subquery,outer query's table. not found	https://zed.brimdata.io/docs/language/operators/over#:~:text=The%20nested%20subquery,outer%20query%27s%20table.
@raviqqe raviqqe added the enhancement New feature or request label Mar 10, 2023
@raviqqe raviqqe moved this to Todo in Muffet Mar 16, 2023
@raviqqe raviqqe added this to Muffet Mar 16, 2023
@Sieboldianus
Copy link

For jekyll-reveal sites, this is rather counterproductive, as it is used as a native URL anchor, e.g.:

https://kartographie.geo.tu-dresden.de/ad/python_datascience_2022/#/35/0/0

I see lots of errors from muffet for these Text Fragments that do point to valid URLs.

raviqqe added a commit that referenced this issue Apr 19, 2023
@raviqqe
Copy link
Owner

raviqqe commented Apr 19, 2023

For now, I made changes to ignore text fragments to avoid unexpected errors in #301.

BTW, at least on Chrome, text fragments can capture texts across element boundaries. That seems to make implementation of text fragment matching easier. 🤣

e.g.

https://zed.brimdata.io/docs/language/operators/over#:~:text=lateral,Synopsis

@raviqqe
Copy link
Owner

raviqqe commented Apr 24, 2024

For my notes, browsers supporting text fragments: https://caniuse.com/?search=text%20fragments%20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants