[CI/Docker] Switch to pytorch new extra index url notation #26072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddelange
requested review from
amogkam,
sven1977,
richardliaw and
matthewdeng
as code owners
ddelange
commented
Jun 24, 2022
ddelange
changed the title
ddelange
force-pushed
the
pytorch-extra-index-url
branch
from
1bc203a
to
1b42f6e
Compare
ddelange
requested review from
wuisawesome,
DmitriGekhtman and
maxpumperla
as code owners
ddelange
force-pushed
the
pytorch-extra-index-url
branch
2 times, most recently
from
21cce50
to
dc02eef
Compare
ddelange
force-pushed
the
pytorch-extra-index-url
branch
2 times, most recently
from
7c99e81
to
82c0ac6
Compare
ddelange
force-pushed
the
pytorch-extra-index-url
branch
4 times, most recently
from
48a36bf
to
9f07440
Compare
ddelange
force-pushed
the
pytorch-extra-index-url
branch
3 times, most recently
from
89a48db
to
c113963
Compare
|
@amogkam CI is green :) |
amogkam
changed the title
ddelange
force-pushed
the
pytorch-extra-index-url
branch
2 times, most recently
from
8b22470
to
8e8235d
Compare
ddelange
commented
Jul 25, 2022
ddelange
force-pushed
the
pytorch-extra-index-url
branch
from
0a4e86c
to
dc2ab64
Compare
|
@amogkam @krfricke pyg-team/pyg-lib#66 was merged 🎉 rebased on latest |
Signed-off-by: ddelange <[email protected]>
ddelange
force-pushed
the
pytorch-extra-index-url
branch
from
dc2ab64
to
98597f3
Compare
ddelange
force-pushed
the
pytorch-extra-index-url
branch
from
ba6937b
to
f4702c9
Compare
|
@amogkam could you help re-running some tests? couldnt find failures related to this PR |
|
cc @krfricke could you help re-run failed tests? |
Signed-off-by: ddelange <[email protected]>
ddelange
force-pushed
the
pytorch-extra-index-url
branch
from
34c1411
to
b30b267
Compare
|
Thanks a lot @ddelange! There is just one last issue with formatting: |
ddelange
commented
Jan 13, 2023
python/ray/train/examples/pytorch_geometric/distributed_sage_example.py
Outdated
Show resolved
Hide resolved
Signed-off-by: ddelange <[email protected]>
|
@amogkam fixed 🤙 |
|
hi @amogkam 👋 could you rerun the failing test? |
|
Hi @amogkam thanks for re-running. it looks like the same flakey failure? https://buildkite.com/ray-project/oss-ci-build-pr/builds/9440#0185b4be-d23f-4de4-acac-4ecf08a921b6 |
Closed
andreapiso
pushed a commit
to andreapiso/ray
that referenced
this pull request
Jan 22, 2023
…ct#26072) torch now provides custom index urls, eliminating the need for the plus-notation and making reqs more readable and maintainable Signed-off-by: ddelange <[email protected]> Signed-off-by: Andrea Pisoni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
torch now provides custom index urls, eliminating the need for the plus-notation and making reqs more readable and maintainable:
Related issue number
followup on #23580
Checks
scripts/format.shto lint the changes in this PR.