[Core][Fix] Fix "No error is raised when the "bind" args does not match the function signature" #47773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkooo567
changed the title
ruisearch42
reviewed
Sep 21, 2024
python/ray/actor.py
Outdated
Comment on lines
271
to
283
| try: | ||
| signature.flatten_args(self._signature, args, kwargs) | ||
| except TypeError as e: | ||
| signature_copy = self._signature.copy() | ||
| if len(signature_copy) > 0 and signature_copy[-1].name == "_ray_trace_ctx": | ||
| # Remove the trace context arg for readability. | ||
| signature_copy.pop(-1) | ||
| signature_copy = inspect.Signature(parameters=signature_copy) | ||
| raise TypeError( | ||
| f"{str(e)}. The function `{self._method_name}` has a signature " | ||
| f"`{signature_copy}`, but it doesn't match a given argument to a " | ||
| f"bind function. args: {args}. kwargs: {kwargs}." | ||
| ) from None |
There was a problem hiding this comment.
Should this be wrapped into another util method like flatten_args in signature.py?
There was a problem hiding this comment.
I created a new API validate_args.
For this question, I feel like adding error message here is better (since it needs to access several private attribute. Feel awkward to create a separate util func)
|
cc @ruisearch42 can you take a look again? |
|
Just noticed this message, I will review soon! |
ruisearch42
approved these changes
Dec 4, 2024
|
Need to fix DCO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
binddoesn't check if the arg matches the signature. Fortunately, we already have the logic in .remote that checks it, and we just use the same mechanism. This also provides very nice error message;Related issue number
Closes #47598
Closes #47709
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.