Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fetch-youtube-transcript extension #15298

Merged
merged 12 commits into from
Nov 26, 2024

Conversation

apoorv12
Copy link
Contributor

@apoorv12 apoorv12 commented Nov 10, 2024

Description

Screencast

Checklist

- CHANGELOG.md file and metadata added
- Initial Commit
@raycastbot raycastbot added the new extension Label for PRs with new extensions label Nov 10, 2024
@raycastbot
Copy link
Collaborator

Congratulations on your new Raycast extension! 🚀

You can expect an initial review within five business days.

Once the PR is approved and merged, the extension will be available on our Store.

@pernielsentikaer
Copy link
Collaborator

Hi 👋

Thanks for your contribution 💪

I have now tested your extension, and I have some feedback ready for you:

  • Make the command no-view instead and add an argument for even faster usage
    Uploading Raycast18112024-Bqj8MFqN.png@2x.png…

  • I didn't change settings but I got this error, could you look into that? I would say it's a good idea if it works out of the box 🙂

I'm looking forward to testing this extension again 🔥

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

@pernielsentikaer pernielsentikaer self-assigned this Nov 18, 2024
@apoorv12
Copy link
Contributor Author

As per your request, I have implemented the following changes:

  • Mode: Enabled the “no-view” mode and added an argument.
  • YouTube Link Addition: Simplified the process of adding a YouTube link. Users can now simply paste the URL or share link.
  • Metadata Image Changes: Adjusted the images in the metadata accordingly.
  • Default Transcript Download Folder: Set the default download folder for transcripts to the “Downloads” folder.

@apoorv12
Copy link
Contributor Author

apoorv12 commented Nov 22, 2024

I have made the changes but Unable to run npm run publish. It showing the following error:
failed running git Command failed: git merge-base --is-ancestor 5e1d306 f68536c && echo "success"

I also ran the following commands but nothing happened:
npx @raycast/api@latest pull-contributions
git fetch origin
git rebase origin/main

Kindly help.

@pernielsentikaer
Copy link
Collaborator

Did you get your fixes in?

@apoorv12
Copy link
Contributor Author

apoorv12 commented Nov 24, 2024 via email

@pernielsentikaer
Copy link
Collaborator

Anything you want me to add?

@apoorv12
Copy link
Contributor Author

No Sir

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit 78768b1 into raycast:main Nov 26, 2024
2 checks passed
Copy link
Contributor

Published to the Raycast Store:
https://raycast.com/apoorv_khandelwal/fetch-youtube-transcript

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@apoorv12).
Please link your GitHub account to your Raycast account to receive your credits and soon be able to exchange them for some swag.

@apoorv12
Copy link
Contributor Author

apoorv12 commented Nov 26, 2024 via email

@apoorv12 apoorv12 deleted the ext/fetch-youtube-transcript branch December 3, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new extension Label for PRs with new extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants