Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update renaming extension #15538

Merged
merged 6 commits into from
Dec 2, 2024
Merged

Update renaming extension #15538

merged 6 commits into from
Dec 2, 2024

Conversation

ridemountainpig
Copy link
Contributor

Description

Add a new Replace File(s) Characters command to change characters in file names.
closes #15484

Screencast

renaming 2024-11-26 at 13 22 05

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: renaming Issues related to the renaming extension OP is contributor The OP of the PR is a contributor of the extension labels Nov 26, 2024
@raycastbot
Copy link
Collaborator

raycastbot commented Nov 26, 2024

Thank you for your contribution! 🎉

🔔 @theodaguier @ridemountainpig you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

@pernielsentikaer
Copy link
Collaborator

Do you have a clue why I don't see the form?

Raycast26112024-z7Jm3yxe png@2x

@pernielsentikaer pernielsentikaer self-assigned this Nov 26, 2024
@ridemountainpig
Copy link
Contributor Author

Do you have a clue why I don't see the form?

I have updated the script to resolve this error. Can you please check it again. Thank you, @pernielsentikaer.

@pernielsentikaer
Copy link
Collaborator

That works better 😊

Nothing happens when I use it, first after the timeout I'll get an error:

16:19:17.534 Error: Command timed out after undefined milliseconds: osascript
Timed out
    at Timeout.<anonymous> (/Users/pernielsentikaer/.config/raycast/extensions/renaming/replace.js:4464:32)
    at listOnTimeout (node:internal/timers:573:17)
    at process.processTimers (node:internal/timers:514:7) {
  timedOut: true,
  signal: 'SIGTERM',
  originalMessage: 'Timed out',
  shortMessage: 'Command timed out after undefined milliseconds: osascript\nTimed out',
  command: 'osascript',
  exitCode: null,
  stdout: '',
  stderr: ''
}

Do you have a clue about that one too?

@ridemountainpig
Copy link
Contributor Author

Nothing happens when I use it, first after the timeout I'll get an error:

16:19:17.534 Error: Command timed out after undefined milliseconds: osascript
Timed out
    at Timeout.<anonymous> (/Users/pernielsentikaer/.config/raycast/extensions/renaming/replace.js:4464:32)
    at listOnTimeout (node:internal/timers:573:17)
    at process.processTimers (node:internal/timers:514:7) {
  timedOut: true,
  signal: 'SIGTERM',
  originalMessage: 'Timed out',
  shortMessage: 'Command timed out after undefined milliseconds: osascript\nTimed out',
  command: 'osascript',
  exitCode: null,
  stdout: '',
  stderr: ''
}

Do you have a clue about that one too?

Weird 😨, it runs normally on my end.

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit 054a71d into raycast:main Dec 2, 2024
2 checks passed
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Published to the Raycast Store:
https://raycast.com/theo_daguier/renaming

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements extension: renaming Issues related to the renaming extension OP is contributor The OP of the PR is a contributor of the extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Renaming] Add search and replace characters in original name
3 participants