Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Premier League] Standings show points for teams with long names #15632

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

jfkisafk
Copy link
Contributor

@jfkisafk jfkisafk commented Dec 1, 2024

Description

  • Fixed standings to show points for teams with long names. Teams with names greater than 20 characters use short names.
  • Updated the dependencies and removed critical security vulnerabilities, plus unnecessary dependencie

Screencast

Screenshot 2024-12-01 at 3 01 53 PM

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: premier-league Issues related to the premier-league extension labels Dec 1, 2024
@raycastbot
Copy link
Collaborator

raycastbot commented Dec 1, 2024

Thank you for your contribution! 🎉

🔔 @anhthang you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

@anhthang
Copy link
Contributor

anhthang commented Dec 2, 2024

Hi @jfkisafk,

Thanks for fixing the issues. I have just face this last night also.
IMO, we can always use shortName to have consistent data for tables. it's also same as what EPL website using in the homepage

image

I also have some small fixes from the main repo here (https://github.com/anhthang/raycast-premier-league/commits/main/) but haven't created PR yet. Can you sync to this to keep the extension is updated?

@anhthang
Copy link
Contributor

anhthang commented Dec 2, 2024

One more thing, I think it's better if we keep using eslint flat config (v9), but not sure what version is preferred by raycast team

@jfkisafk
Copy link
Contributor Author

jfkisafk commented Dec 2, 2024

One more thing, I think it's better if we keep using eslint flat config (v9), but not sure what version is preferred by raycast team

Yeah while using v9 and trying to extend raycast config, it was creating a lot of resolve conflicts with peer dependency. I think most packages extending @raycast eslint config are using eslint@8 atm, so we can stick to that.

@pernielsentikaer
Copy link
Collaborator

Can you ping me when it's ready to be merged?

@pernielsentikaer pernielsentikaer self-assigned this Dec 2, 2024
@jfkisafk
Copy link
Contributor Author

jfkisafk commented Dec 2, 2024

Hi @pernielsentikaer this PR is ready to be merged

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit 3175e5a into raycast:main Dec 2, 2024
2 checks passed
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Published to the Raycast Store:
https://raycast.com/anhthang/premier-league

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

@jfkisafk jfkisafk deleted the ext/epl branch December 2, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements extension: premier-league Issues related to the premier-league extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Premier League] Points redacted for teams with long names
4 participants