Lower os versions, add guards #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondjavaxx
approved these changes
Apr 20, 2024
There was a problem hiding this comment.
Hi @mattmassicotte,
Thank you for contributing this! I'm glad you found the package useful. 🚢
|
Ohh, CI is a messed up now. I’ll have a look at this! |
|
I just merged a CI fix in #17. The |
|
Yes! GitHub actions requires a bit of babysitting there 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
First, thanks for making this package. I've been using it for quite a while and it's great.
I'm just about to start using it in a new project, and I'd like to keep the OS version requirements low. However, I wasn't able, because this package has them just a little higher than I need. However, lowering them wasn't too hard, just had to add a few availability guards here and there.
I also bumped the package swift version. This might seem paradoxical, but I think it is reasonable to require 5.9 (Xcode 14) as a minimum. And that will allow supporting visionOS explicitly.