Consume/deployment #284
Merged
Consume/deployment #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vnktram
commented
Dec 13, 2021
•
vnktram
commented
- Fetch ordinal ID from host name
- Load ordinal ID to consumeConfig. Part of [WIP] Consume plane setup #283
Codecov Report
@@ Coverage Diff @@
## consume-plane #284 +/- ##
==============================================
Coverage 45.63% 45.63%
==============================================
Files 110 110
Lines 5125 5125
==============================================
Hits 2339 2339
Misses 2611 2611
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
razorao
reviewed
Dec 20, 2021
| @@ -10,6 +10,8 @@ initialize() | |||
| return | |||
| fi | |||
|
|
|||
| export METRO_CONSUMEPLANE_ORDINALID=${HOSTNAME##*-} | |||
There was a problem hiding this comment.
Did not understand the ##*-.
Please explain.
There was a problem hiding this comment.
kubernetes/kubernetes#40651
We need to fetch the ordinal ID for each pod of the stateful set.
Currently, k8s downstream APIs do not expose this field.
Hence the workaround - kubernetes/kubernetes#40651 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.