Paymentlink fix (#366)

razorpay · Jul 18, 2023 · 9e36e95 · 9e36e95
1 parent d447ddf
commit 9e36e95
Show file tree

Hide file tree

Showing 5 changed files with 35 additions and 26 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 2.9.1 - 2023-07-13
+
+fix: Create paymentLink request
+
 ## 2.9.0 - 2023-06-30
 
 feat: Added new API endpoints

diff --git a/lib/api.js b/lib/api.js
@@ -73,12 +73,19 @@ class API {
         form: params.data
       };
 
-      if(params.hasOwnProperty('formData')){
-        delete request['form'];
-        request.formData = params.formData;
-      }
+    if (params.hasOwnProperty('formData')) {
+      delete request['form'];
+      request.formData = params.formData;
+    }
+    return nodeify(this.rq.post(request).catch(normalizeError), cb);
+  }
 
-      return nodeify(this.rq.post(request).catch(normalizeError), cb);
+  postBody(params, cb) {
+    let request = {
+       url: this.getEntityUrl(params),
+       body: params.data
+     };
+   return nodeify(this.rq.post(request).catch(normalizeError), cb);
   }
 
   put(params, cb) {
@@ -90,18 +97,18 @@ class API {
 
   patch(params, cb) {
     let request = {
-         url: this.getEntityUrl(params),
-         form: params.data
-       };
-
-      if(params.data.hasOwnProperty("isbody")) {
-        delete request['form'];
-        delete params.data.isbody;
-        request.body = params.data;
-      }
-      return nodeify(this.rq.patch(request).catch(normalizeError), cb);
+      url: this.getEntityUrl(params),
+      form: params.data
+    };
+
+    if(params.data.hasOwnProperty("isbody")) {
+      delete request['form'];
+      delete params.data.isbody;
+      request.body = params.data;
     }
-
+    return nodeify(this.rq.patch(request).catch(normalizeError), cb);
+  }
+
   delete(params, cb) {
     return nodeify(this.rq.delete({
       url: this.getEntityUrl(params)

diff --git a/lib/resources/paymentLink.js b/lib/resources/paymentLink.js
@@ -14,7 +14,7 @@ module.exports = function paymentLinkApi (api) {
 
   return {
 
-    create (params={}, callback) {
+    create (params, callback) {
 
       /*
        * Creates Payment Link.
@@ -25,14 +25,11 @@ module.exports = function paymentLinkApi (api) {
        * @return {Promise}
        */
 
-      let url = BASE_URL,
-          { notes, ...rest } = params,
-          data = Object.assign(params);
-
-      return api.post({
+      let url = BASE_URL;
+      return api.postBody({
         url,
-        data
-      }, callback,true)
+        data: params
+      }, callback)
     },
     cancel (paymentLinkId, callback) {
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "razorpay",
-  "version": "2.9.0",
+  "version": "2.9.1",
   "description": "Official Node SDK for Razorpay API",
   "main": "dist/razorpay",
   "typings": "dist/razorpay",

diff --git a/test/resources/paymentLink.spec.js b/test/resources/paymentLink.spec.js
@@ -51,7 +51,8 @@ describe("PAYMENTLINK", () => {
       };
       mocker.mock({
         url: `/payment_links`,
-        method: 'POST'
+        method: 'POST',
+        ignoreParseBody: true
       })
 
       rzpInstance.paymentLink.create(params).then((response) => {