-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Hires. fix values #45
Comments
Good to know! thank you |
What about the hires steps in Auto1111, how can those be set in dream factory? I would like to take a 512x768 image apply a second hires pass with steps and scale up by 2x. I can do this with upscale in dream factory but it is only a blown up version of the 512 image where as auto1111 produces a slightly different/clearer image with the box mentioned unchecked. |
You can do that with a !MODE = process .prompts file currently. Take a look at example-process.prompts in the /prompts directory for an explanation of how they work. Note that you will need to have MAX_OUTPUT_SIZE set in your config.txt file for this to work. See config-default.txt for instructions on how to set it. Basically, you want to create a .prompts file containing something like this and run it:
|
hmmm, I must be doing something wrong... the resolution is being scaled up, however auto1111 produces a slightly different image still. Here are some screenshots so you can see what I mean. For hires fix, use width/height sliders is unchecked in auto1111. Here is the image in auto1111 Here is what dream factory produces with the closest settings I can find. Setting highres_fix to yes creates a totally different image. in dream factory I get the same image using upscale in the standard prompt or using it in the process prompt. Here is my prompt file [config] !MODE = standard # standard mode; queue all possible combinations of [prompts] below !WIDTH = 512 # output image width !USE_UPSCALE = yes # upscale output images? !NEG_PROMPT = blurry, out of focus, chromatic abberations, (low quality, worst quality:1.2), bad hands, poorly drawn face, watermark, text, poorly drawn hands, username, lowres, (EasyNegative), (bad_prompt_version2), (negative_hand), (verybadimagenegative_v1.3) [prompts] cute adorable girl, (3d disney pixar style:1.2), (arms above head:1.4), age 19, (anna of arendelle:1.1), (adorable female:1.2), green pleated skirt, braided hair, (skirt:1.4), perfect teeth, perfect human face, (perfect hands:1.2), (on a mountain:1.2), (best quality, masterpiece, 4k, sharp focus, 8k, high definition:1.2) lora:lit:0.6 lora:anna_of_arendelle_v22:0.75 |
It looks like you're upscaling at generation time in DF, which will use ESRGAN by default. DF uses the original hires fix method implemented in Auto1111, which doesn't allow specifying anything other than final output size. The best way to mimic the new Auto1111 hires method in DF currently is to generate small images initially (in your case 512x768). And then use a You can also upscale directly from DF's built-in gallery by clicking the upscale icon (or pressing 'U') on the image you want to upscale. This requires that |
That works thank you! I didnt realize the difference between sd and ESRGAN. Do you have any plans to implement auto1111's new method of upscaling? |
It's been a minute, but the newer hires fix/upscale method is supported in the latest version: https://github.com/rbbrdckybk/dream-factory/blob/main/CHANGELOG.md#20230922 |
Thanks for this update. I'm trying to sort out the best value to insert in the config file. I continue to get this error when requesting an upscale from the viewer Can you share a recommended example for using the latest/best model, settings, and process to upscaling a folder of images? I know every machine and intent is different, but curious if you have a general recommendation to help me get started. |
The upscale operation that I built into the gallery probably needs to be re-done based on newer methods. It currently uses SD Upscale, which provides good quality but is limited by the amount of GPU VRAM that you have. With 12GB VRAM, I'm barely able to get 3MP upscaled images, which isn't very large at all. That error indicates that the source image is already as large (or larger) than SD Upscale would be able to give you, based on the MAX_OUTPUT_SIZE that you specified in your config.txt. Instead, I highly recommend going the Ultimate SD Upscale route for upscaling images in Dream Factory - you'll need to have the extension installed in Auto1111 first. After that, copy & paste the script below into an empty .prompts file and run it after making a couple minor changes:
|
I don't see if there's a way to define the values for the hires. fix like:
Upscaler
,Hires steps
,Denosing strength
.What values are used today if I wanted to reproduce an exact output from dream-factory in a1111?
The text was updated successfully, but these errors were encountered: