Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic order for union typeguard generation #117

Open
jackTabsCode opened this issue Jan 24, 2025 · 1 comment
Open

Deterministic order for union typeguard generation #117

jackTabsCode opened this issue Jan 24, 2025 · 1 comment
Labels
domain: transformer Exclusively related to the transformer. enhancement New feature or request

Comments

@jackTabsCode
Copy link

jackTabsCode commented Jan 24, 2025

When using Flamework.createGuard<T> where T contains a union, that generated guard will sometimes change between compiles without a change in the source. This is undesirable behavior for me because I'm comparing the emit of typeguards in unit tests

@Fireboltofdeath Fireboltofdeath added enhancement New feature or request domain: transformer Exclusively related to the transformer. labels Jan 24, 2025
@Fireboltofdeath
Copy link
Member

Similar behavior also has to be implemented for user macro unions which are also currently not deterministic, the same machinery will likely be used for both user macros and type guards.

I'll likely have to revisit implementing user macro determinism, I did have a branch with the implementation previously but I wasn't happy with the performance of it so I shelved that version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: transformer Exclusively related to the transformer. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants