-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Pubsub Framework #279
Conversation
WARNING: A Blackduck scan failure has been waivedA prior failure has been upvoted
|
{ | ||
let mut ripple_context = self.ripple_context.write().unwrap(); | ||
ripple_context.deep_copy(context); | ||
if is_main // This part of code is for the main ExntClient to handle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new section of code handles the below expectation for Main's extension client to forward the event between one extension to the other.
Authorization to check whether a given Extension has the authority to send the event to the other extension is defined in the manifest with ExtnSender forward_event
checks for the contract permissions. So this code is basically a pass through from and extension to main and then to the actual extension.
We will implement a separate change to just emit events from extension to extension without needing to go through main similar to how we handle the response for requests.
Minimum allowed line rate is Current coverage:13% exceeds coverage threshold. Coverage threshold will be updated automatically to reflect to the latest coverage when this pr is merged to main branch. |
What
What does this PR add or remove?
Why
Why are these changes needed?
How
This PR introduces structures that enable extensions to send and receive Pubsub-related requests, responses, and events
Test
I've tested it using test extensions
Checklist