Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pubsub Framework #279

Merged
merged 47 commits into from
Feb 5, 2024
Merged

feat: Pubsub Framework #279

merged 47 commits into from
Feb 5, 2024

Conversation

Karthick-Somasundaresan
Copy link
Contributor

@Karthick-Somasundaresan Karthick-Somasundaresan commented Oct 17, 2023

What

What does this PR add or remove?

Why

Why are these changes needed?

How

This PR introduces structures that enable extensions to send and receive Pubsub-related requests, responses, and events

Test

I've tested it using test extensions

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@satlead satlead requested a review from a team October 30, 2023 13:03
@rdkcmf-jenkins
Copy link

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 2 files pending identification.

  • Protex Server Path: /home/blackduck/github/Ripple/279/rdkcentral/Ripple

  • Commit: d326813

Report detail: gist

@rdkcmf-jenkins
Copy link

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 2 files pending identification.

  • Protex Server Path: /home/blackduck/github/Ripple/279/rdkcentral/Ripple

  • Commit: 3561e55

Report detail: gist

@rdkcmf-jenkins
Copy link

WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

  • Upvote reason: Not a problem

  • Commit: 3561e55

{
let mut ripple_context = self.ripple_context.write().unwrap();
ripple_context.deep_copy(context);
if is_main // This part of code is for the main ExntClient to handle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new section of code handles the below expectation for Main's extension client to forward the event between one extension to the other.

Authorization to check whether a given Extension has the authority to send the event to the other extension is defined in the manifest with ExtnSender forward_event checks for the contract permissions. So this code is basically a pass through from and extension to main and then to the actual extension.

We will implement a separate change to just emit events from extension to extension without needing to go through main similar to how we handle the response for requests.

Copy link

github-actions bot commented Feb 5, 2024

Code Coverage

Package Line Rate Health
core.sdk.src.api.device 41%
core.sdk.src 100%
core.sdk.src.api.manifest 31%
device.thunder.src.bootstrap 0%
device.thunder_ripple_sdk.src.processors.events 0%
core.main.src 6%
core.main.src.service 30%
device.thunder_ripple_sdk.src.bootstrap 0%
core.main.src.state 21%
core.sdk.src.utils 48%
core.main.src.firebolt 1%
device.thunder_ripple_sdk.src.client 15%
core.main.src.service.extn 27%
core.sdk.src.extn 38%
core.sdk.src.extn.ffi 24%
core.main.src.utils 13%
core.sdk.src.api 3%
core.main.src.bootstrap.manifest 0%
core.main.src.bootstrap 0%
core.launcher.src 1%
core.main.src.firebolt.handlers 2%
core.tdk.src 100%
core.tdk.src.utils 80%
device.thunder.src 2%
core.sdk.src.api.gateway 32%
distributor.general.src 2%
core.sdk.src.extn.client 9%
core.sdk.src.api.distributor 0%
core.tdk.src.gateway 100%
core.main.src.state.cap 44%
core.sdk.src.api.firebolt 25%
core.main.src.processor 0%
device.thunder_ripple_sdk.src.events 4%
core.launcher.src.manager 7%
core.main.src.processor.storage 0%
device.thunder_ripple_sdk.src.processors 4%
core.main.src.bootstrap.extn 0%
core.sdk.src.framework 67%
core.main.src.service.apps 20%
device.thunder_ripple_sdk.src 14%
Summary 13% (3621 / 26867)

Minimum allowed line rate is 10%

Current coverage:13% exceeds coverage threshold. Coverage threshold will be updated automatically to reflect to the latest coverage when this pr is merged to main branch.

@Karthick-Somasundaresan Karthick-Somasundaresan merged commit 4b93f9b into main Feb 5, 2024
8 checks passed
@Karthick-Somasundaresan Karthick-Somasundaresan deleted the pubsub_framework_1 branch February 5, 2024 15:23
@Nv-Delle1416 Nv-Delle1416 added this to the ripple-1.3.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants