Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1: Add unit and intergration test for Ripple thunder_broker. #730

Merged
merged 8 commits into from
Feb 25, 2025

Conversation

Vinodsathyaseelan
Copy link
Contributor

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@Vinodsathyaseelan Vinodsathyaseelan force-pushed the RPPL-2088 branch 7 times, most recently from 3be9dd0 to 669fd38 Compare February 17, 2025 18:17
@Vinodsathyaseelan Vinodsathyaseelan force-pushed the RPPL-2088 branch 5 times, most recently from 32b8f9d to 5f30aa8 Compare February 17, 2025 22:39
@Vinodsathyaseelan Vinodsathyaseelan force-pushed the RPPL-2088 branch 3 times, most recently from 615dbdb to 3299406 Compare February 18, 2025 01:13
Copy link
Collaborator

@satlead satlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool implementation of a L1 framework. Please make this available for ThunderAsyncClient to use this as well.

@Vinodsathyaseelan Vinodsathyaseelan force-pushed the RPPL-2088 branch 2 times, most recently from 3a3d468 to dcee8ff Compare February 24, 2025 22:09
Copy link

github-actions bot commented Feb 25, 2025

Code Coverage

Package Line Rate Health
core.sdk.src.extn.ffi 80%
core.sdk.src.extn.client 88%
core.main.src.bootstrap.extn 0%
device.thunder.src 0%
core.tdk.src.utils 0%
core.sdk.src.api.device 77%
core.sdk.src.extn 83%
core.main.src.bootstrap.manifest 0%
core.main.src.broker.test 93%
core.sdk.src.api.firebolt 77%
core.main.src.processor.storage 0%
distributor.general.src 2%
core.launcher.src.manager 7%
core.main.src.state 22%
device.mock_device.src 54%
core.sdk.src.processor 0%
device.thunder_ripple_sdk.src.bootstrap 0%
core.sdk.src.api.manifest 89%
core.sdk.src.framework 76%
device.thunder_ripple_sdk.src.processors 13%
openrpc_validator.src 68%
device.thunder_ripple_sdk.src.processors.events 0%
core.main.src.bootstrap 0%
core.main.src.utils 26%
core.sdk.src.api.distributor 84%
core.main.src.service 31%
core.tdk.src.gateway 100%
core.main.src.service.apps 48%
core.main.src.processor 0%
core.main.src 0%
core.main.src.service.extn 40%
core.sdk.src.utils 49%
core.main.src.broker 55%
device.thunder.src.bootstrap 0%
device.thunder_ripple_sdk.src 17%
device.thunder_ripple_sdk.src.client 66%
core.main.src.state.cap 43%
core.launcher.src 0%
core.sdk.src.api.observability 58%
core.main.src.firebolt.handlers 9%
core.main.src.broker.thunder 39%
core.sdk.src.api.gateway 65%
device.thunder_ripple_sdk.src.events 4%
core.main.src.firebolt 3%
core.sdk.src.api 74%
Summary 45% (19900 / 44597)

Minimum allowed line rate is 42%

Current coverage:45% exceeds coverage threshold. Coverage threshold will be updated automatically to reflect to the latest coverage when this pr is merged to main branch.

@Vinodsathyaseelan Vinodsathyaseelan merged commit 91f3fc0 into main Feb 25, 2025
7 checks passed
@Vinodsathyaseelan Vinodsathyaseelan deleted the RPPL-2088 branch February 25, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants