Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.css is not included in /assets for v7.4.30 #288

Closed
gnoyixiang opened this issue Oct 11, 2019 · 4 comments
Closed

index.css is not included in /assets for v7.4.30 #288

gnoyixiang opened this issue Oct 11, 2019 · 4 comments

Comments

@gnoyixiang
Copy link

Hello, I updated to v7.4.30 and I got this error when importing /assets/index.css

Module not found: Can't resolve 'rc-menu/assets/index.css'

Only the index.less file is included in /assets
Can the css file be added back?
I will use v7.4.29 for now until this is fixed.

Thanks!

@zombieJ
Copy link
Member

zombieJ commented Oct 11, 2019

Need volunteer to help on this.

ref: react-component/tree#263 (comment)

@zombieJ
Copy link
Member

zombieJ commented Oct 12, 2019

@zombieJ zombieJ closed this as completed Oct 12, 2019
@dsarfati
Copy link

This still doesn't seem to work when using CRA. During the yarn install process I see the assets folder but then it gets removed later on during Cleaning Modules phase.

@dsarfati
Copy link

Discovered that this is an issue with yarn and not CRA. The default/recommended .yarnclean file includes assets. I simply needed to add !rc-menu/assets to the end of the .yarnclean file so the css isn't removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants