Merge pull request #9 from Ronaldvdh-ISAAC/fix-generatePkceChallenge

fix: generatePkceChallenge

Author: panz3r

src/__tests__/uuid.spec.ts

@@ -0,0 +1,18 @@
+import { generatePkceChallenge, generateCodeVerifier } from '../utils/uuid';
+
+describe('utils', () => {
+  describe('uuid', () => {
+    describe('generatePkceChallenge', () => {
+      it('should generate a pkce challenge', () => {
+        // Arrange
+        const codeVerifier = generateCodeVerifier(96);
+
+        // Act
+        const pkceChallenge = generatePkceChallenge('S256', codeVerifier);
+
+        // Assert
+        expect(pkceChallenge.length).toBeGreaterThan(0);
+      });
+    });
+  });
+});

src/utils/uuid.ts

@@ -44,9 +44,8 @@ export function generatePkceChallenge(
     // The use of the "plain" method is considered insecure and therefore not supported.
     case 'S256':
       // hash codeVerifier, then encode as url-safe base64 without padding
-      const hashBytes = sha256.arrayBuffer(codeVerifier);
-      // new Uint8Array(sha256_imported.arrayBuffer(codeVerifier));
-      const encodedHash = fromByteArray(hashBytes as Uint8Array)
+      const hashBytes = new Uint8Array(sha256.arrayBuffer(codeVerifier));
+      const encodedHash = fromByteArray(hashBytes)
         .replace(/\+/g, '-')
         .replace(/\//g, '_')
         .replace(/\=/g, '');