Replies: 6 comments 4 replies
-
Yes please, I sometimes accidentally press 'i' or 'a' and then get infuriated 😆 |
Beta Was this translation helpful? Give feedback.
-
I only use those commands every now and then. I don't think this would negatively impact my day-to-day development experience with React Native. |
Beta Was this translation helpful? Give feedback.
-
Thanks all! Intending to ship in facebook/react-native#46781 (on |
Beta Was this translation helpful? Give feedback.
-
I'm totally agree! |
Beta Was this translation helpful? Give feedback.
-
Same as @tjzel, happens to me way to often. |
Beta Was this translation helpful? Give feedback.
-
not opposed to this change (alongside the above, it also seems less confusing to only have one entry point), but I do want to note that, at least for me, |
Beta Was this translation helpful? Give feedback.
-
What
Remove the "run ion iOS" and "run on Android" options from
npx react-native start
.Motivation
TLDR: The existing
android
/ios
commands provide a convenience mechanism to triggerstart
(in a new terminal), but let's remove the hooks for doing this the other way round. Frameworks are better placed to make decisions around orchestrating these parts.Quality — incomplete and buggy CLI output
Our dev server should only be concerned with the first party actions of serving JS bundles and supporting debugging (all key commands except Android/iOS). These actions don't create distracting noise for the user and complete very quickly.
Conversely, for "run ion iOS", "run on Android":
console
, and not via Metro's buffered terminal API.stderr
output — meaning a failed native build will output nothing, and just hang as the dev server continues to listen!Maintenance and lack of feature fit in core
npx react-native
commands, keeps a strong dependency on@react-native-community/cli-plugin-android
and@react-native-community/cli-plugin-ios
.Alternatives
None needed.
react-native android|ios
commands, which will open a terminal window forreact-native start
(the same dev server) if needed. Post Frameworks, we don't need the convenience of doing this both ways round.Beta Was this translation helpful? Give feedback.
All reactions