Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme switches when I switch component variant #72

Closed
zementeshome opened this issue Jul 18, 2022 · 6 comments
Closed

Theme switches when I switch component variant #72

zementeshome opened this issue Jul 18, 2022 · 6 comments
Labels

Comments

@zementeshome
Copy link

Hi there,

I'm running into an issue with the theme switching whenever I click on a different variant. I have primary, secondary and tertiary variants for my button component. For example, when I select a different theme and click on secondary, it ends up selecting the first theme in the array and applies the styles for the secondary button for that theme.

I noticed in your demo when I select Light Theme 2, I'm able to click on Buttons 1, 2 and 3 and see the theme apply to all the variants and it stays on the selected theme.

Attached is a gif.

2022-07-18 14 34 10

@zementeshome
Copy link
Author

@usulpro any help would be greatly appreciated!

@usulpro usulpro added the bug label Jul 21, 2022
@usulpro
Copy link
Member

usulpro commented Jul 21, 2022

@zementeshome thanks for reporting this. Indeed the theme should persist. It looks like we have a bug here

@usulpro
Copy link
Member

usulpro commented Jul 21, 2022

@zementeshome
we released a 1.1.7 with hotfix

@usulpro usulpro closed this as completed Jul 21, 2022
@zementeshome
Copy link
Author

@usulpro yay, working now! thank you.

@Evgeny-Timoshin-R3
Copy link

@usulpro I am experiencing the same behaviour in 1.1.10. With Material UI, is the bug back?

@zementeshome
Copy link
Author

@Evgeny-Timoshin-R3 @usulpro i'm also experiencing this bug again in 1.1.10 and we're using chakra. thanks for calling this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants