Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ready-to-use CSS to distribution package #197

Closed
adamkudrna opened this issue Nov 13, 2020 · 4 comments · Fixed by #491
Closed

Add ready-to-use CSS to distribution package #197

adamkudrna opened this issue Nov 13, 2020 · 4 comments · Fixed by #491
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@adamkudrna
Copy link
Member

adamkudrna commented Nov 13, 2020

All we need is to document two styling options:

  1. Import a ready-to-use compiled CSS reactui.css.
  2. Import source Sass files from src/scss.

All Sass endpoints should be compiled to CSS, minified (but keep the unminified version too), and placed in dist:

  • foundation(.min).css
  • helpers(.min).css
  • theme(.min).css
  • components(.min).css

src can then be excluded from publishing. Sass source files remain intact.

Suggested Webpack plugin (maybe it's no longer the right choice): https://webpack.js.org/plugins/mini-css-extract-plugin/#minimal-example

@adamkudrna adamkudrna changed the title Deal with SCSS endpoints for usage Replace SCSS endpoints with ready-to-use CSS Nov 13, 2020
@adamkudrna adamkudrna self-assigned this Nov 13, 2020
@adamkudrna adamkudrna added the BC Breaking change label Feb 4, 2021
@adamkudrna adamkudrna changed the title Replace SCSS endpoints with ready-to-use CSS Add ready-to-use CSS to distribution package May 3, 2021
@adamkudrna adamkudrna added feature and removed BC Breaking change labels May 3, 2021
@adamkudrna adamkudrna added this to the v1.0.0 milestone Dec 20, 2021
@adamkudrna adamkudrna removed their assignment Aug 2, 2022
@hubacekj
Copy link
Contributor

hubacekj commented Aug 8, 2022

The mini-css-extract-plugin still seems as the right choice, but it needs Webpack 5 to work (#358).

@adamkudrna adamkudrna moved this to 🔖 Ready in The Board Aug 21, 2022
@mbohal mbohal assigned mbohal and unassigned hubacekj Nov 14, 2022
@mbohal
Copy link
Contributor

mbohal commented Nov 14, 2022

I will work on it along with #373

@mbohal
Copy link
Contributor

mbohal commented Jul 26, 2023

Once #440 gets merged the files will be available in docs/_assets/generated.

This issue then needs to:

  • Update docs
  • Ensure they are available correctly when RUI is installed via npm

@bedrich-schindler bedrich-schindler moved this from 🏗 In progress to 🔖 To do in The Board Sep 4, 2023
@bedrich-schindler
Copy link
Contributor

According to @mbohal, description is not up-to-date and need to be updated, see message in Slack.

@mbohal mbohal assigned hubacekj and unassigned bedrich-schindler and hubacekj Sep 11, 2023
@adamkudrna adamkudrna moved this from 🔖 To do to 🏗 In progress in The Board Sep 13, 2023
@adamkudrna adamkudrna moved this from 🏗 In progress to 👀 In review in The Board Sep 18, 2023
@adamkudrna adamkudrna added documentation Improvements or additions to documentation and removed feature labels Sep 18, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in The Board Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants