Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a neutral type of change in changelog #418

Open
adamkudrna opened this issue Aug 21, 2022 · 5 comments
Open

Introduce a neutral type of change in changelog #418

adamkudrna opened this issue Aug 21, 2022 · 5 comments

Comments

@adamkudrna
Copy link
Member

Something can be just a change — not a feature, not refactoring, not patch, just a change.

@adamkudrna adamkudrna moved this to 🆕 New in The Board Aug 21, 2022
@mbohal
Copy link
Contributor

mbohal commented Aug 22, 2022

I disagree, I think we should close this issue. Nobody does changes for no reason and therefore the current categories should be enough.

Generally we make changes with the aim to:

  • improve something -> feature
  • fix something -> bugfix
  • improve code quality -> refactoring

I can not envision change that would not fall in these categories.

Also the more categories we have the more complicated will the contribution process get. And we do not want it to be complicated.

@adamkudrna
Copy link
Member Author

What if you change e.g. Tabs border color to a slightly different shade of gray? It doesn't introduce anything new nor it doesn't fix anything. It may be a design improvement (although calling it a feature sounds too much to me), but from the code point of view it's just a change.

@mbohal
Copy link
Contributor

mbohal commented Sep 19, 2022

It doesn't introduce anything new nor it doesn't fix anything.

Why bother doing it then when it brings no benefit?

@adamkudrna
Copy link
Member Author

A better design may be the benefit. For me, that is worth doing.

@mbohal
Copy link
Contributor

mbohal commented Sep 20, 2022

A better design may be the benefit. For me, that is worth doing.

But a design improvement is a feature, no? As you wrote above:

improve something -> feature

If it is not a feature, I could envision a design type change. I think we don't need it, but if you think we do I'm fine with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 💡Ideas
Development

No branches or pull requests

2 participants