Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further refactor modifier classnames #425

Open
hubacekj opened this issue Sep 23, 2022 · 0 comments
Open

Further refactor modifier classnames #425

hubacekj opened this issue Sep 23, 2022 · 0 comments
Labels
BC Breaking change
Milestone

Comments

@hubacekj
Copy link
Contributor

Looking at the modifier classes, I think we could further unify their names instead of attempting to build sentence-like names: .isToolbarAlignedToTop ➡️ .isToolbarAlignTop, etc. The pattern would be:

  1. .is<ELEMENT><PROP-NAME><PROP-VALUE> for oneOf prop types, e.g. .isRootColorPrimary,
  2. .is<ELEMENT><PROP-NAME> for truthy boolean prop types, e.g. .isRootBlock.

If you agree, I'd do it in a separate PR (or a commit at least) and also document it in part 4.

Originally posted by @adamkudrna in #424 (comment)

@adamkudrna adamkudrna moved this to 🆕 New in The Board Oct 10, 2022
@adamkudrna adamkudrna moved this from 🆕 New to 📋 Backlog in The Board Oct 10, 2022
@adamkudrna adamkudrna moved this from 📋 Backlog to 🆕 New in The Board Oct 10, 2022
@adamkudrna adamkudrna moved this from 🆕 New to 📤 Next in The Board Oct 17, 2022
@adamkudrna adamkudrna moved this from 📤 Next to 📋 Backlog in The Board Nov 28, 2022
@adamkudrna adamkudrna added BC Breaking change and removed refactoring labels Sep 2, 2024
@adamkudrna adamkudrna added this to the v1.0.0 milestone Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Breaking change
Projects
Status: 🔖 To do
Development

No branches or pull requests

2 participants