You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looking at the modifier classes, I think we could further unify their names instead of attempting to build sentence-like names: .isToolbarAlignedToTop ➡️ .isToolbarAlignTop, etc. The pattern would be:
.is<ELEMENT><PROP-NAME><PROP-VALUE> for oneOf prop types, e.g. .isRootColorPrimary,
.is<ELEMENT><PROP-NAME> for truthy boolean prop types, e.g. .isRootBlock.
If you agree, I'd do it in a separate PR (or a commit at least) and also document it in part 4.
Looking at the modifier classes, I think we could further unify their names instead of attempting to build sentence-like names:
.isToolbarAlignedToTop
➡️.isToolbarAlignTop
, etc. The pattern would be:.is<ELEMENT><PROP-NAME><PROP-VALUE>
foroneOf
prop types, e.g..isRootColorPrimary
,.is<ELEMENT><PROP-NAME>
for truthy boolean prop types, e.g..isRootBlock
.If you agree, I'd do it in a separate PR (or a commit at least) and also document it in part 4.
Originally posted by @adamkudrna in #424 (comment)
The text was updated successfully, but these errors were encountered: