Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix asset size validation #470

Open
mbohal opened this issue Jul 26, 2023 · 0 comments
Open

Fix asset size validation #470

mbohal opened this issue Jul 26, 2023 · 0 comments
Labels
maintenance performance skip changelog Pull request will be excluded from change log
Milestone
v1.0.0

Comments

@mbohal
Copy link
Contributor

mbohal commented Jul 26, 2023

presently we are using the same numbers for:

I think that makes no sense. The way I see it we only need to worry about maxAssetSize, but maybe I'm wrong. Either way it makes no sense to use the same values for both.
@mbohal mbohal added this to The Board Jul 26, 2023
@github-project-automation github-project-automation bot moved this to 💡Ideas in The Board Jul 26, 2023
@mbohal mbohal moved this from 💡Ideas to 🔖 To do in The Board Jul 26, 2023
@mbohal mbohal added this to the v1.0.0 milestone Jul 26, 2023
@mbohal mbohal added maintenance performance skip changelog Pull request will be excluded from change log labels Jul 26, 2023
@mbohal mbohal mentioned this issue Jul 26, 2023
Merged
@adamkudrna adamkudrna changed the title Fix asset side validation Fix asset size validation Aug 7, 2023
@adamkudrna adamkudrna removed this from the v1.0.0 milestone Sep 2, 2024
@mbohal mbohal added this to the v1.0.0 milestone Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance performance skip changelog Pull request will be excluded from change log
Projects
The Board
Status: 🔖 To do
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@mbohal @adamkudrna