Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage CSS cascade layers to fix and user-proof styles order #518

Closed
adamkudrna opened this issue Dec 20, 2023 · 0 comments · Fixed by #529
Closed

Leverage CSS cascade layers to fix and user-proof styles order #518

adamkudrna opened this issue Dec 20, 2023 · 0 comments · Fixed by #529
Assignees
@adamkudrna
Labels
feature

Comments

@adamkudrna
Copy link
Member

adamkudrna commented Dec 20, 2023 •
edited
Loading

This is a follow-up issue of #517.

As a result of #440, component styles are no longer part of the JS bundle. They reside in the extracted react-ui[.development].css file. The order of styles in this stylesheet is incorrect and may cause styling issues.

The reason of the incorrect order is in the call order in src/index.js: first, there are imports (theme, foundation, ⚠️ helpers ⚠️), then exports (components).

Cascade layers will help keep the styles in correct order, no matter how they are called.
@adamkudrna adamkudrna converted this from a draft issue Dec 20, 2023
@adamkudrna adamkudrna self-assigned this Dec 20, 2023
@adamkudrna adamkudrna mentioned this issue Dec 20, 2023
Closed
@adamkudrna adamkudrna moved this from 💡Ideas to 🔖 To do in The Board Mar 6, 2024
@adamkudrna adamkudrna changed the title Leverage CSS cascade layers to user-proof styles order Leverage CSS cascade layers to fix and user-proof styles order Mar 6, 2024
@adamkudrna adamkudrna moved this from 🔖 To do to 🏗 In progress in The Board Mar 6, 2024
@adamkudrna adamkudrna mentioned this issue Mar 6, 2024
Merged
@adamkudrna adamkudrna moved this from 🏗 In progress to 👀 In review in The Board Mar 6, 2024
@adamkudrna adamkudrna linked a pull request Mar 6, 2024 that will close this issue
Leverage CSS cascade layers to fix and user-proof styles order #529
Merged
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in The Board Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamkudrna adamkudrna

Labels
feature
Projects
The Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Leverage CSS cascade layers to fix and user-proof styles order react-ui-org/react-ui
1 participant
@adamkudrna