Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misplaced Popover when used with Floating UI #566

Open
adamkudrna opened this issue Sep 11, 2024 · 2 comments · May be fixed by #576
Open

Misplaced Popover when used with Floating UI #566

adamkudrna opened this issue Sep 11, 2024 · 2 comments · May be fixed by #576
Labels
bug Something isn't working
Milestone
v1.0.0

Comments

@adamkudrna
Copy link
Member

I found out the advanced positioning is now broken. It is not related to this PR and it was already broken before, but if you could fix it here, it would be great. Otherwise let's file a separate issue for it.

Image

#559 (comment)
@adamkudrna adamkudrna converted this from a draft issue Sep 11, 2024
@adamkudrna adamkudrna added this to the v1.0.0 milestone Sep 11, 2024
@adamkudrna adamkudrna added the bug Something isn't working label Sep 11, 2024
@adamkudrna adamkudrna mentioned this issue Sep 11, 2024
Merged
@mbohal mbohal self-assigned this Sep 16, 2024
@mbohal mbohal removed their assignment Nov 11, 2024
@atmelmicro
Copy link
Collaborator

This happens because transferProps disallows the prop style which is needed for Floating UI to work properly. Wrapping the popover in a div does not help because the dimensions of the div are 0x0. Making it work without passing style would require a lot of ugly tweaks on the user side.

I have 2 solutions in mind.

  1. Allow the prop style to be passed
  2. Make a new prop for floating ui and pass only top, left, and position

The 2nd one would discourage abusing the style prop, but some other libraries may need more props to work

@mbohal
Copy link
Contributor

mbohal commented Nov 18, 2024

On video call we agreed, that we want a new prop position to pass the position info.

atmelmicro added a commit that referenced this issue Nov 19, 2024
@atmelmicro
Fix misplaced when using Floating UI (#566)
e592d2c
atmelmicro added a commit that referenced this issue Nov 19, 2024
@atmelmicro
Fix misplaced Popover when using Floating UI (#566)
05094c7
@atmelmicro atmelmicro linked a pull request Nov 19, 2024 that will close this issue
Open
@mbohal mbohal moved this from 🔖 To do to 👀 In review in The Board Nov 30, 2024
atmelmicro added a commit that referenced this issue Dec 10, 2024
@atmelmicro
fixup! Fix misplaced Popover when using Floating UI (#566)
a9a60fa
atmelmicro added a commit that referenced this issue Dec 10, 2024
@atmelmicro
fixup! fixup! Fix misplaced Popover when using Floating UI (#566)
45c0bc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
The Board
Status: 👀 In review
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Fix misplaced Popover when using Floating UI (#566) react-ui-org/react-ui
3 participants
@mbohal @adamkudrna @atmelmicro