Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the new component template generator script #33

Open
mikemurray opened this issue Jul 24, 2019 · 1 comment
Open

Update the new component template generator script #33

mikemurray opened this issue Jul 24, 2019 · 1 comment
Labels
documentation For issues that describe mistakes in documentation or missing docs, including in code comments

Comments

@mikemurray
Copy link
Member

Type: minor

Describe the bug
Template generator script has syntax errors and doesn't follow the best practices for Catalyst components.

@machikoyasuda
Copy link
Contributor

Converts all @material-ui/core imports more than 1 level deep to the optimal form for tree shaking:
Before
-import withStyles from '@material-ui/core/styles/withStyles';
-import createMuiTheme from '@material-ui/core/styles/createMuiTheme';

=>
 
after V.4.0
+import { withStyles, createMuiTheme } from '@material-ui/core/styles';
top-level-imports
Converts all @material-ui/core submodule imports to the root module:

before
-import List from '@material-ui/core/List';
-import { withStyles } from '@material-ui/core/styles';

after 4.0
+import { List, withStyles } from '@material-ui/core';

@machikoyasuda machikoyasuda self-assigned this Jul 29, 2019
@machikoyasuda machikoyasuda added the documentation For issues that describe mistakes in documentation or missing docs, including in code comments label Aug 30, 2019
@machikoyasuda machikoyasuda removed their assignment Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation For issues that describe mistakes in documentation or missing docs, including in code comments
Projects
None yet
Development

No branches or pull requests

3 participants