Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On a fresh windows 10 install reaction not started due to vsivsi:job-collection #2210

Closed
hrath2015 opened this issue May 4, 2017 · 7 comments
Assignees
Labels
bug For issues that describe a defect or regression in the released software help wanted For issues that have a clear solution described and are not currently prioritized core team work

Comments

@hrath2015
Copy link
Collaborator

Expected behavior

Reaction App Should start

Actual Behavior

Application Start Stuck without any message. (Most Frustrating part)

Steps to Reproduce the Behavior

On a fresh windows 10 install reaction not started due to vsivsi:job-collection.
When pinned(downgraded ) vsivsi:job-collection from 1.5.1 to 1.4.0, it worked.

Versions

Node: 6.3.1
NPM: 3.10.3
Reaction CLI: 0.8.0
Reaction: 1.1.1
Reaction Branch: development

@brent-hoover
Copy link
Collaborator

brent-hoover commented May 4, 2017

@hrath2015 Have you looked at/commented on vsivsi/meteor-job-collection#231
Seems like you aren't the only one.

@hrath2015
Copy link
Collaborator Author

@zenweasel thanks for pointing it out and referencing the issue as well. I was away for almost 3 weeks and after coming back started to get all kind of problems 😟 while building the RC locally. felt this one should be logged. Lots has changed in 3 weeks (reaction-cli, meteor version upgrade and vsivsi).
thanks again...

@aaronjudd aaronjudd added needs-to-be-reproduced help wanted For issues that have a clear solution described and are not currently prioritized core team work bug For issues that describe a defect or regression in the released software labels May 8, 2017
@aaronjudd
Copy link
Contributor

@hrath2015 @zenweasel if we want to pin to 1.4.0 -> what's the downside?

@brent-hoover brent-hoover self-assigned this May 8, 2017
@hrath2015
Copy link
Collaborator Author

RC Master branch is still using 1.4.0. I tested it with a fresh clone reaction init and reaction run and versions file has vsivsi:[email protected].

Also looked at changes between 1.5.1 and 1.4.0 at https://github.com/vsivsi/meteor-job-collection/blob/master/HISTORY.md . Not much changes there. I feel we can pin it to 1.4.0 and hoping we have a solution in near future.
@zenweasel request your views as well. If decision is to pin then I will send a PR.

@brent-hoover
Copy link
Collaborator

@hrath2015 Have you tried pinning the current development version to 1.4? I think the decision was to pin it to 1.4 if there was no other downside. We did need to fix one bit of syntax that changed from 1.4 to 1.5, but not sure if it's backwards compatible

@hrath2015
Copy link
Collaborator Author

@zenweasel Yes I did pin on development branch and saw no issues.

@brent-hoover
Copy link
Collaborator

Closed via #2228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software help wanted For issues that have a clear solution described and are not currently prioritized core team work
Projects
None yet
Development

No branches or pull requests

3 participants