Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow children from import sources with the same package scope #535

Closed
rmorshea opened this issue Nov 18, 2021 Discussed in #534 · 1 comment
Closed

Allow children from import sources with the same package scope #535

rmorshea opened this issue Nov 18, 2021 Discussed in #534 · 1 comment
Labels
priority-2-moderate Should be resolved on a reasonable timeline.

Comments

@rmorshea
Copy link
Collaborator

rmorshea commented Nov 18, 2021

Discussed in #534

If the import sources of two web modules are different, but have the same package scope, then they should be allow to be children of each other. There may be a more general way of indicating that two import sources are compatible with each other. Since the main goal of restricting what what import sources can or can't be children of each other is to ensure that they are using the same instance of React, maybe import sources can indicate this somehow, either through their name or metadata attached to their import source dict.

@rmorshea rmorshea added the bug label Nov 18, 2021
@rmorshea rmorshea added this to the 2.0 milestone Jan 11, 2022
@rmorshea rmorshea added the priority-2-moderate Should be resolved on a reasonable timeline. label Jan 13, 2022
@Archmonger Archmonger modified the milestones: Luxury, Essential Jan 29, 2023
@rmorshea rmorshea removed this from the Essential milestone Feb 21, 2023
@Archmonger
Copy link
Contributor

Closed in favor of #1262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-2-moderate Should be resolved on a reasonable timeline.
Projects
None yet
Development

No branches or pull requests

2 participants